From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-owner@vger.kernel.org>
Received: from szxga01-in.huawei.com ([58.251.152.64]:2207 "EHLO
	szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751106AbbD3DY5 (ORCPT
	<rfc822;stable@vger.kernel.org>); Wed, 29 Apr 2015 23:24:57 -0400
Message-ID: <5541A076.2000101@huawei.com>
Date: Thu, 30 Apr 2015 11:24:38 +0800
From: Zefan Li <lizefan@huawei.com>
MIME-Version: 1.0
To: Wang Kai <morgan.wang@huawei.com>
CC: <gregkh@linuxfoundation.org>, <viro@zeniv.linux.org.uk>,
	<stable@vger.kernel.org>
Subject: Re: [PATCH] get rid of s_files and files_lock
References: <1430305255-55947-1-git-send-email-morgan.wang@huawei.com> <1430305255-55947-2-git-send-email-morgan.wang@huawei.com>
In-Reply-To: <1430305255-55947-2-git-send-email-morgan.wang@huawei.com>
Content-Type: text/plain; charset="GB2312"
Content-Transfer-Encoding: 7bit
Sender: stable-owner@vger.kernel.org
List-ID: <stable.vger.kernel.org>

On 2015/4/29 19:00, Wang Kai wrote:
> From: Al Viro <viro@zeniv.linux.org.uk>
> 
> commit eee5cc2702929fd41cce28058dc6d6717f723f87 upstream.
> 
> The only thing we need it for is alt-sysrq-r (emergency remount r/o)
> and these days we can do just as well without going through the
> list of files.
> 
> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
> [wangkai: backport to 3.10
>  - address CVE-2014-8172
>  - adjust context
>  - leave fu.fu_list as still used in 3.10]

This doesn't sound right to me. We're removing operations on fu_list like
init/add/del, so how can it still be used?