From: Shreyas B Prabhu <shreyas@linux.vnet.ibm.com>
To: Preeti Murthy <preeti.lkml@gmail.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Paul McKenney <paulmck@linux.vnet.ibm.com>,
LKML <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@redhat.com>,
aneesh.kumar@linux.vnet.ibm.com,
Preeti U Murthy <preeti@linux.vnet.ibm.com>
Subject: Re: [PATCH 3/3] tracing/mm: Don't trace mm_page_pcpu_drain on offline cpus
Date: Thu, 30 Apr 2015 10:11:35 +0530 [thread overview]
Message-ID: <5541B27F.5040200@linux.vnet.ibm.com> (raw)
In-Reply-To: <CAM4v1pM_92Lqkw+1H7JQHCHmzDeH9Kj_HeyqpZXZnnDd+PFC2A@mail.gmail.com>
On Thursday 30 April 2015 10:06 AM, Preeti Murthy wrote:
> On Wed, Apr 29, 2015 at 10:49 PM, Shreyas B Prabhu
> <shreyas@linux.vnet.ibm.com> wrote:
>>
>>
>> On Wednesday 29 April 2015 10:38 PM, Steven Rostedt wrote:
>>>> I am not sure if its worth the effort now. It doesn't look like any
>>>> other trace point apart from the above use case will benefit from it.
>>>> Only smbus_write and smbus_reply seem to come close. But even they need
>>>> separate TP_fast_assign.
>>>
>>> It shouldn't be a problem to implement. But I'm currently cleaning up
>>> those files, and any changes will cause nasty conflicts.
>>>
>>> Lets do this. Push the current changes as is, and when I get around to
>>> adding a DEFINE_EVENT_PRINT_CONDITION(), we can modify that code to use
>>> it.
>>>
>> Okay, sure.
>
> Looks good then.
>
> Reviewed-by: Preeti U Murthy <preeti@linux.vnet.ibm.com>
Thanks a lot!
next prev parent reply other threads:[~2015-04-30 4:42 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-28 15:51 [PATCH 1/3] tracing/mm: Don't trace kmem_cache_free on offline cpus Shreyas B. Prabhu
2015-04-28 15:51 ` [PATCH 2/3] tracing/mm: Don't trace mm_page_free " Shreyas B. Prabhu
2015-04-29 9:06 ` Preeti Murthy
2015-04-29 9:07 ` Preeti Murthy
2015-04-28 15:51 ` [PATCH 3/3] tracing/mm: Don't trace mm_page_pcpu_drain " Shreyas B. Prabhu
2015-04-29 9:13 ` Preeti Murthy
2015-04-29 14:49 ` Shreyas B Prabhu
2015-04-29 15:18 ` Steven Rostedt
2015-04-29 15:58 ` Shreyas B Prabhu
2015-04-29 17:08 ` Steven Rostedt
2015-04-29 17:19 ` Shreyas B Prabhu
2015-04-30 4:36 ` Preeti Murthy
2015-04-30 4:41 ` Shreyas B Prabhu [this message]
2015-05-08 4:37 ` Shreyas B Prabhu
2015-05-08 14:18 ` Steven Rostedt
2015-05-08 16:39 ` Shreyas B Prabhu
2015-04-29 9:04 ` [PATCH 1/3] tracing/mm: Don't trace kmem_cache_free " Preeti Murthy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5541B27F.5040200@linux.vnet.ibm.com \
--to=shreyas@linux.vnet.ibm.com \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=preeti.lkml@gmail.com \
--cc=preeti@linux.vnet.ibm.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.