From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@citrix.com>
Subject: Re: [PATCH v2 2/3] xen/arm: Add p2m_pfn_bits
Date: Thu, 30 Apr 2015 10:39:19 +0100
Message-ID: <5541F847.7070204@citrix.com>
References: <1430374003-22789-1-git-send-email-edgar.iglesias@gmail.com>
	<1430374003-22789-3-git-send-email-edgar.iglesias@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1430374003-22789-3-git-send-email-edgar.iglesias@gmail.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>, xen-devel@lists.xen.org
Cc: julien.grall@citrix.com, edgar.iglesias@xilinx.com, tim@xen.org, ian.campbell@citrix.com, stefano.stabellini@citrix.com
List-Id: xen-devel@lists.xenproject.org

Hi Edgar,

On 30/04/2015 07:06, Edgar E. Iglesias wrote:
>       val |= VTCR_T0SZ(0x18); /* 40 bit IPA */
>       val |= VTCR_SL0(0x1); /* P2M starts at first level */
>   #else /* CONFIG_ARM_64 */
> @@ -1557,6 +1561,7 @@ void __init setup_virt_paging(void)
>
>       p2m_root_order = pa_range_info[pa_range].root_order;
>       p2m_root_level = 2 - pa_range_info[pa_range].sl0;
> +    p2m_pfn_bits = 64 - pa_range_info[pa_range].t0sz;

You are mixing IPA (Intermediate Physical Address) and PFN (Page Frame 
Number) which have to 2 distinct meaning.

In this case, we are dealing with IPA. Please rename the variable to 
p2m_ipa_bits and replace PFN by IPA in all the patch.

Regards,

-- 
Julien Grall