From mboxrd@z Thu Jan 1 00:00:00 1970 From: Caesar Wang Subject: Re: [PATCH] i2c: rk3x: Increase wait timeout to 1 second Date: Fri, 01 May 2015 11:40:37 +0800 Message-ID: <5542F5B5.9000206@163.com> References: <1430430247-9632-1-git-send-email-dianders@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1430430247-9632-1-git-send-email-dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+glpar-linux-rockchip=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Doug Anderson , Wolfram Sang Cc: Addy Ke , Max Schwarz , Heiko Stuebner , Dmitry Torokhov , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: linux-i2c@vger.kernel.org CgrlnKggMjAxNeW5tDA15pyIMDHml6UgMDU6NDQsIERvdWcgQW5kZXJzb24g5YaZ6YGTOgo+IFdo aWxlIGl0J3Mgbm90IHNlbnNpYmxlIGZvciBhbiBpMmMgY29tbWFuZCB0byBfYWN0dWFsbHlfIG5l ZWQgbW9yZQo+IHRoYW4gMjAwbXMgdG8gY29tcGxldGUsIGxldCdzIGluY3JlYXNlIHRoZSB0aW1l b3V0IGFueXdheS4gIFdoeT8gIEl0Cj4gdHVybnMgb3V0IHRoYXQgaWYgeW91J3ZlIGdvdCBhIGxh cmdlIG51bWJlciBvZiBwcmludGtzIGdvaW5nIG91dCB0byBhCj4gc2VyaWFsIGNvbnNvbGUsIGlu dGVycnVwdHMgb24gYSBDUFUgY2FuIGJlIGRpc2FibGVkIGZvciBodW5kcmVkcyBvZgo+IG1pbGxp c2Vjb25kcy4gVGhhdCdzIG5vdCBhIGdyZWF0IHNpdHVhdGlvbiB0byBiZSBpbiB0byBzdGFydCB3 aXRoCj4gKG1heWJlIHdlIHNob3VsZCBwdXQgYSBjYXAgaW4gdnByaW50a19lbWl0KCkpIGJ1dCBp dCdzIHByZXR0eSBhbm5veWluZwo+IHRvIHN0YXJ0IHNlZWluZyB1bmV4cGxhaW5lZCBpMmMgdGlt ZW91dHMuCj4KPiBBIG5vcm1hbCBzeXN0ZW0gc2hvdWxkbid0IHNlZSBpMmMgdGltZW91dHMgYW55 d2F5LCBzbyBpbmNyZWFzaW5nIHRoZQo+IHRpbWVvdXQgc2hvdWxkIGhlbHAgcGVvcGxlIGRlYnVn Z2luZyB3aXRob3V0IGh1cnRpbmcgb3RoZXIgcGVvcGxlCj4gZXhjZXNzaXZlbHkuCj4KPiBTaWdu ZWQtb2ZmLWJ5OiBEb3VnIEFuZGVyc29uIDxkaWFuZGVyc0BjaHJvbWl1bS5vcmc+Cj4gLS0tCj4g ICBkcml2ZXJzL2kyYy9idXNzZXMvaTJjLXJrM3guYyB8IDIgKy0KPiAgIDEgZmlsZSBjaGFuZ2Vk LCAxIGluc2VydGlvbigrKSwgMSBkZWxldGlvbigtKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMv aTJjL2J1c3Nlcy9pMmMtcmszeC5jIGIvZHJpdmVycy9pMmMvYnVzc2VzL2kyYy1yazN4LmMKPiBp bmRleCAwMTlkNTQyLi43MmU5N2UzMCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2kyYy9idXNzZXMv aTJjLXJrM3guYwo+ICsrKyBiL2RyaXZlcnMvaTJjL2J1c3Nlcy9pMmMtcmszeC5jCj4gQEAgLTcy LDcgKzcyLDcgQEAgZW51bSB7Cj4gICAjZGVmaW5lIFJFR19JTlRfQUxMICAgICAgIDB4N2YKPiAg IAo+ICAgLyogQ29uc3RhbnRzICovCj4gLSNkZWZpbmUgV0FJVF9USU1FT1VUICAgICAgMjAwIC8q IG1zICovCj4gKyNkZWZpbmUgV0FJVF9USU1FT1VUICAgICAgMTAwMCAvKiBtcyAqLwpZZWFoLCB2 ZXJpZmllZCBvbiB2ZXlyb24gZGV2aWNlLgoKVGVzdGVkLWJ5OiBDYWVzYXIgV2FuZyA8d3h0QHJv Y2stY2hpcHMuY29tPgoKCgpUaGFua3MuCgpDYWVzYXIKPiAgICNkZWZpbmUgREVGQVVMVF9TQ0xf UkFURSAgKDEwMCAqIDEwMDApIC8qIEh6ICovCj4gICAKPiAgIGVudW0gcmszeF9pMmNfc3RhdGUg ewoKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpMaW51 eC1yb2NrY2hpcCBtYWlsaW5nIGxpc3QKTGludXgtcm9ja2NoaXBAbGlzdHMuaW5mcmFkZWFkLm9y ZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LXJvY2tj aGlwCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: sasukewxt@163.com (Caesar Wang) Date: Fri, 01 May 2015 11:40:37 +0800 Subject: [PATCH] i2c: rk3x: Increase wait timeout to 1 second In-Reply-To: <1430430247-9632-1-git-send-email-dianders@chromium.org> References: <1430430247-9632-1-git-send-email-dianders@chromium.org> Message-ID: <5542F5B5.9000206@163.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org ? 2015?05?01? 05:44, Doug Anderson ??: > While it's not sensible for an i2c command to _actually_ need more > than 200ms to complete, let's increase the timeout anyway. Why? It > turns out that if you've got a large number of printks going out to a > serial console, interrupts on a CPU can be disabled for hundreds of > milliseconds. That's not a great situation to be in to start with > (maybe we should put a cap in vprintk_emit()) but it's pretty annoying > to start seeing unexplained i2c timeouts. > > A normal system shouldn't see i2c timeouts anyway, so increasing the > timeout should help people debugging without hurting other people > excessively. > > Signed-off-by: Doug Anderson > --- > drivers/i2c/busses/i2c-rk3x.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/i2c/busses/i2c-rk3x.c b/drivers/i2c/busses/i2c-rk3x.c > index 019d542..72e97e30 100644 > --- a/drivers/i2c/busses/i2c-rk3x.c > +++ b/drivers/i2c/busses/i2c-rk3x.c > @@ -72,7 +72,7 @@ enum { > #define REG_INT_ALL 0x7f > > /* Constants */ > -#define WAIT_TIMEOUT 200 /* ms */ > +#define WAIT_TIMEOUT 1000 /* ms */ Yeah, verified on veyron device. Tested-by: Caesar Wang Thanks. Caesar > #define DEFAULT_SCL_RATE (100 * 1000) /* Hz */ > > enum rk3x_i2c_state { From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753234AbbEADmv (ORCPT ); Thu, 30 Apr 2015 23:42:51 -0400 Received: from m50-135.163.com ([123.125.50.135]:39084 "EHLO m50-135.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751077AbbEADms (ORCPT ); Thu, 30 Apr 2015 23:42:48 -0400 Message-ID: <5542F5B5.9000206@163.com> Date: Fri, 01 May 2015 11:40:37 +0800 From: Caesar Wang User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Doug Anderson , Wolfram Sang CC: Addy Ke , Dmitry Torokhov , Heiko Stuebner , Max Schwarz , linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] i2c: rk3x: Increase wait timeout to 1 second References: <1430430247-9632-1-git-send-email-dianders@chromium.org> In-Reply-To: <1430430247-9632-1-git-send-email-dianders@chromium.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-CM-TRANSID: D9GowABnIG+19UJVGJHLBQ--.383S3 X-Coremail-Antispam: 1Uf129KBjvJXoW7Kr1DuFW3uw18tr1DGFW8Crg_yoW8Gr4Upr 47Ka92krn0qFy2g3Z7JF13XryFqay8W3yjgr9xKrykuFs8J3Z7Cwsrtay5uFyv9ryjkr42 q3yqqa43CF4jy37anT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07jxa93UUUUU= X-Originating-IP: [110.90.45.118] X-CM-SenderInfo: 5vdv3yhhz03qqrwthudrp/1tbiShjslVO-tImOAAAAs0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2015年05月01日 05:44, Doug Anderson 写道: > While it's not sensible for an i2c command to _actually_ need more > than 200ms to complete, let's increase the timeout anyway. Why? It > turns out that if you've got a large number of printks going out to a > serial console, interrupts on a CPU can be disabled for hundreds of > milliseconds. That's not a great situation to be in to start with > (maybe we should put a cap in vprintk_emit()) but it's pretty annoying > to start seeing unexplained i2c timeouts. > > A normal system shouldn't see i2c timeouts anyway, so increasing the > timeout should help people debugging without hurting other people > excessively. > > Signed-off-by: Doug Anderson > --- > drivers/i2c/busses/i2c-rk3x.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/i2c/busses/i2c-rk3x.c b/drivers/i2c/busses/i2c-rk3x.c > index 019d542..72e97e30 100644 > --- a/drivers/i2c/busses/i2c-rk3x.c > +++ b/drivers/i2c/busses/i2c-rk3x.c > @@ -72,7 +72,7 @@ enum { > #define REG_INT_ALL 0x7f > > /* Constants */ > -#define WAIT_TIMEOUT 200 /* ms */ > +#define WAIT_TIMEOUT 1000 /* ms */ Yeah, verified on veyron device. Tested-by: Caesar Wang Thanks. Caesar > #define DEFAULT_SCL_RATE (100 * 1000) /* Hz */ > > enum rk3x_i2c_state {