All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Fu, Zhonghui" <zhonghui.fu@linux.intel.com>
To: Arend van Spriel <arend@broadcom.com>
Cc: "brudley@broadcom.com" <brudley@broadcom.com>,
	Franky Lin <frankyl@broadcom.com>,
	"meuleman@broadcom.com" <meuleman@broadcom.com>,
	Kalle Valo <kvalo@codeaurora.org>,
	"pieterpg@broadcom.com" <pieterpg@broadcom.com>,
	"hdegoede@redhat.com" <hdegoede@redhat.com>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	"brcm80211-dev-list@broadcom.com"
	<brcm80211-dev-list@broadcom.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] brcmfmac: keep WiFi chip's power during system suspension
Date: Fri, 01 May 2015 14:26:32 +0800	[thread overview]
Message-ID: <55431C98.9030203@linux.intel.com> (raw)
In-Reply-To: <553DF923.5070300@broadcom.com>



On 2015/4/27 16:53, Arend van Spriel wrote:
> On 04/27/15 07:06, Fu, Zhonghui wrote:
>> Need to keep the power supply for WiFi chip during system suspension.
>> Otherwise, the context of WiFi chip will be lost.
>
> I already submitted a patch doing exactly the same thing [1]

OK, please ignore this patch.

What's the target kernel version of your patch?

Thanks,
Zhonghui
>
> Regards,
> Arend
>
> [1] https://patchwork.kernel.org/patch/6217391/
>
>> Signed-off-by: Zhonghui Fu<zhonghui.fu@linux.intel.com>
>> ---
>>   drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c |   10 ++++++----
>>   1 files changed, 6 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c b/drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c
>> index fdf8feb..03d3671 100644
>> --- a/drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c
>> +++ b/drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c
>> @@ -1251,15 +1251,17 @@ static int brcmf_ops_sdio_suspend(struct device *dev)
>>       brcmf_sdiod_freezer_on(sdiodev);
>>       brcmf_sdio_wd_timer(sdiodev->bus, 0);
>>
>> +    sdio_flags = MMC_PM_KEEP_POWER;
>>       if (sdiodev->wowl_enabled) {
>> -        sdio_flags = MMC_PM_KEEP_POWER;
>>           if (sdiodev->pdata->oob_irq_supported)
>>               enable_irq_wake(sdiodev->pdata->oob_irq_nr);
>>           else
>> -            sdio_flags = MMC_PM_WAKE_SDIO_IRQ;
>> -        if (sdio_set_host_pm_flags(sdiodev->func[1], sdio_flags))
>> -            brcmf_err("Failed to set pm_flags %x\n", sdio_flags);
>> +            sdio_flags |= MMC_PM_WAKE_SDIO_IRQ;
>>       }
>> +
>> +    if (sdio_set_host_pm_flags(sdiodev->func[1], sdio_flags))
>> +        brcmf_err("Failed to set pm_flags %x\n", sdio_flags);
>> +
>>       return 0;
>>   }
>>
>> -- 1.7.1
>>
>


      reply	other threads:[~2015-05-01  6:26 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-27  5:06 [PATCH 2/2] brcmfmac: keep WiFi chip's power during system suspension Fu, Zhonghui
2015-04-27  8:53 ` Arend van Spriel
2015-05-01  6:26   ` Fu, Zhonghui [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55431C98.9030203@linux.intel.com \
    --to=zhonghui.fu@linux.intel.com \
    --cc=arend@broadcom.com \
    --cc=brcm80211-dev-list@broadcom.com \
    --cc=brudley@broadcom.com \
    --cc=frankyl@broadcom.com \
    --cc=hdegoede@redhat.com \
    --cc=kvalo@codeaurora.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=meuleman@broadcom.com \
    --cc=netdev@vger.kernel.org \
    --cc=pieterpg@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.