Re: [PATCH v3 4/5] xen: arm: map child MMIO and IRQs to dom0 for PCI bus DT nodes.

[Julien Grall <julien.grall@citrix.com>]

On 01/05/15 13:42, Ian Campbell wrote:
> On Wed, 2015-04-29 at 17:22 +0100, Julien Grall wrote:
>> Hi Ian,
>>
>> On 20/04/15 13:16, Ian Campbell wrote:
>>> +static int map_interrupt_to_domain(const struct dt_device_node *dev,
>>> +                                   const struct dt_raw_irq *dt_raw_irq,
>>> +                                   void *data)
>>> +{
>>
>> [..]
>>
>>> +    res = route_irq_to_guest(d, dt_irq.irq, dt_irq.irq, dt_node_name(dev));
>>> +    if ( res < 0 )
>>> +    {
>>> +        printk(XENLOG_ERR "Unable to map IRQ%"PRId32" to dom%d\n",
>>> +               dt_irq.irq, d->domain_id);
>>> +        return res;
>>> +    }
>>
>> You forgot to give the IRQ permission to the domain.
> 
> Oops! I suppose that would only be noticeable when trying to pass it
> through which is why I didn't see it?

Right. I would only notice during PCI-passthrough which is not yet
supported.

-- 
Julien Grall