All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Vrabel <david.vrabel@citrix.com>
To: Tim Deegan <tim@xen.org>, David Vrabel <david.vrabel@citrix.com>
Cc: Keir Fraser <keir@xen.org>, Jan Beulich <jbeulich@suse.com>,
	Christoph Egger <chegger@amazon.de>, Matt Wilson <msw@amazon.com>,
	xen-devel@lists.xenproject.org,
	Malcolm Crossley <malcolm.crossley@citrix.com>,
	Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCHv7 2/3] gnttab: refactor locking for scalability
Date: Fri, 1 May 2015 19:03:02 +0100	[thread overview]
Message-ID: <5543BFD6.4010405@citrix.com> (raw)
In-Reply-To: <20150430143409.GF13575@deinos.phlegethon.org>

On 30/04/15 15:34, Tim Deegan wrote:
> 
> OK, so here we hold rd->grant_table->lock and act->lock (which is in
> the rd table) and are going to acquire lgt->maptrack_lock in mapcount().
> 
> That means we can't ever have a path holding domA's maptrack lock that
> acquires domB's gt lock or one of domB's act->locks.  I think that's
> OK because after this patch the only paths left that hold the maptrack
> lock can't acquire anything except an act->lock of the same domain.
> Do I understand that correctly?
> 
> Also: because mapcount() itself doesn't take any act->lock, there's no
> path that holds two act->locks at the same time?

Um. I think it's easier if we just say you cannot take another lock
while holding a maptrack_lock since that's currently the case.

David

  reply	other threads:[~2015-05-01 18:03 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-30 13:28 [PATCHv7 0/3] gnttab: Improve scaleability David Vrabel
2015-04-30 13:28 ` [PATCHv7 1/3] gnttab: Introduce rwlock to protect updates to grant table state David Vrabel
2015-05-05 10:42   ` Jan Beulich
2015-04-30 13:28 ` [PATCHv7 2/3] gnttab: refactor locking for scalability David Vrabel
2015-04-30 14:34   ` Tim Deegan
2015-05-01 18:03     ` David Vrabel [this message]
2015-05-01 20:02       ` Tim Deegan
2015-05-05 11:58   ` Jan Beulich
2015-04-30 13:28 ` [PATCHv7 3/3] gnttab: use per-VCPU maptrack free lists David Vrabel
2015-04-30 15:12   ` Tim Deegan
2015-05-01 12:29     ` Malcolm Crossley
2015-05-05 12:34   ` Jan Beulich
2015-05-12 11:01     ` David Vrabel
2015-05-12 11:37       ` Jan Beulich
2015-05-12 12:37         ` David Vrabel
2015-05-12 12:56           ` Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5543BFD6.4010405@citrix.com \
    --to=david.vrabel@citrix.com \
    --cc=chegger@amazon.de \
    --cc=ian.campbell@citrix.com \
    --cc=jbeulich@suse.com \
    --cc=keir@xen.org \
    --cc=malcolm.crossley@citrix.com \
    --cc=msw@amazon.com \
    --cc=tim@xen.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.