From: Laura Abbott <laura@labbott.name>
To: Hillf Danton <hillf.zj@alibaba-inc.com>
Cc: "'Russell King'" <rmk+kernel@arm.linux.org.uk>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux@arm.linux.org.uk
Subject: Re: [patch] ARM: fix module-bound check in setting page attributes
Date: Fri, 01 May 2015 11:25:45 -0700 [thread overview]
Message-ID: <5543C529.4080203@labbott.name> (raw)
In-Reply-To: <042801d066b3$0ca78a30$25f69e90$@alibaba-inc.com>
On 3/24/15 9:20 PM, Hillf Danton wrote:
> It was introduced in commit f2ca09f381a59
> (ARM: 8311/1: Don't use is_module_addr in setting page attributes)
>
> We have no need to check start twice, but see if end is also in range.
>
> Signed-off-by: Hillf Danton <hillf.zj@alibaba-inc.com>
> ---
>
> --- a/arch/arm/mm/pageattr.c Wed Mar 25 11:55:13 2015
> +++ b/arch/arm/mm/pageattr.c Wed Mar 25 11:57:31 2015
> @@ -52,7 +52,7 @@ static int change_memory_common(unsigned
> if (start < MODULES_VADDR || start >= MODULES_END)
> return -EINVAL;
>
> - if (end < MODULES_VADDR || start >= MODULES_END)
> + if (end < MODULES_VADDR || end >= MODULES_END)
> return -EINVAL;
>
> data.set_mask = set_mask;
> --
>
>
Sorry for the delay, that e-mail address is being phased out.
Please remember to Cc linux-arm-kernel when sending anything
in arch/arm. If this hasn't been picked up, please resend
with linux-arm-kernel Cc'ed and you can add
Acked-by: Laura Abbott <laura@labbott.name>
next prev parent reply other threads:[~2015-05-01 18:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-25 4:20 [patch] ARM: fix module-bound check in setting page attributes Hillf Danton
2015-04-07 8:30 ` Hillf Danton
2015-04-14 6:20 ` Hillf Danton
2015-05-01 18:25 ` Laura Abbott [this message]
2015-05-04 2:52 ` Hillf Danton
2015-05-04 2:52 ` Hillf Danton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5543C529.4080203@labbott.name \
--to=laura@labbott.name \
--cc=hillf.zj@alibaba-inc.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=rmk+kernel@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.