From mboxrd@z Thu Jan 1 00:00:00 1970 From: Krzysztof Kozlowski Subject: Re: [PATCH] ARM: SAMSUNG: fix clk_enable() WARNing in S3C24XX ADC Date: Sat, 02 May 2015 16:15:00 +0900 Message-ID: <55447974.4050209@gmail.com> References: <1430112584-6170-1-git-send-email-sakib@meta.ua> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: Received: from mail-pa0-f50.google.com ([209.85.220.50]:34754 "EHLO mail-pa0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750920AbbEBHPF (ORCPT ); Sat, 2 May 2015 03:15:05 -0400 Received: by pacyx8 with SMTP id yx8so111344267pac.1 for ; Sat, 02 May 2015 00:15:04 -0700 (PDT) In-Reply-To: <1430112584-6170-1-git-send-email-sakib@meta.ua> Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: Sergiy Kibrik , linux-arm-kernel@lists.infradead.org Cc: linux-samsung-soc@vger.kernel.org W dniu 27.04.2015 o 14:29, Sergiy Kibrik pisze: > Convert clk_enable/clk_disable to clk_prepare_enable/clk_disable_unprepare > calls as required by common clock framework. Removes this warning on probe: > > ------------[ cut here ]------------ > WARNING: CPU: 0 PID: 1 at drivers/clk/clk.c:889 __clk_enable+0x28/0x9c() > Modules linked in: > CPU: 0 PID: 1 Comm: swapper Not tainted 3.19.0+ #46 > [] (unwind_backtrace) from [] (show_stack+0x10/0x14) > [] (show_stack) from [] (warn_slowpath_common+0x7c/0xa4) > [] (warn_slowpath_common) from [] (warn_slowpath_null+0x18/0x20) > [] (warn_slowpath_null) from [] (__clk_enable+0x28/0x9c) > [] (__clk_enable) from [] (clk_enable+0x18/0x2c) > [] (clk_enable) from [] (s3c_adc_probe+0x11c/0x18c) > [] (s3c_adc_probe) from [] (platform_drv_probe+0x30/0x78) > [] (platform_drv_probe) from [] (driver_probe_device+0xb0/0x1fc) > [] (driver_probe_device) from [] (__driver_attach+0x68/0x88) > [] (__driver_attach) from [] (bus_for_each_dev+0x70/0x94) > [] (bus_for_each_dev) from [] (bus_add_driver+0xdc/0x1c4) > [] (bus_add_driver) from [] (driver_register+0x9c/0xe0) > [] (driver_register) from [] (adc_init+0x10/0x34) > [] (adc_init) from [] (do_one_initcall+0x110/0x1cc) > [] (do_one_initcall) from [] (kernel_init_freeable+0xf4/0x1ac) > [] (kernel_init_freeable) from [] (kernel_init+0x8/0xe0) > [] (kernel_init) from [] (ret_from_fork+0x14/0x3c) > ---[ end trace f4a1ea39a114fecf ]--- > > Signed-off-by: Sergiy Kibrik Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 From: k.kozlowski.k@gmail.com (Krzysztof Kozlowski) Date: Sat, 02 May 2015 16:15:00 +0900 Subject: [PATCH] ARM: SAMSUNG: fix clk_enable() WARNing in S3C24XX ADC In-Reply-To: <1430112584-6170-1-git-send-email-sakib@meta.ua> References: <1430112584-6170-1-git-send-email-sakib@meta.ua> Message-ID: <55447974.4050209@gmail.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org W dniu 27.04.2015 o 14:29, Sergiy Kibrik pisze: > Convert clk_enable/clk_disable to clk_prepare_enable/clk_disable_unprepare > calls as required by common clock framework. Removes this warning on probe: > > ------------[ cut here ]------------ > WARNING: CPU: 0 PID: 1 at drivers/clk/clk.c:889 __clk_enable+0x28/0x9c() > Modules linked in: > CPU: 0 PID: 1 Comm: swapper Not tainted 3.19.0+ #46 > [] (unwind_backtrace) from [] (show_stack+0x10/0x14) > [] (show_stack) from [] (warn_slowpath_common+0x7c/0xa4) > [] (warn_slowpath_common) from [] (warn_slowpath_null+0x18/0x20) > [] (warn_slowpath_null) from [] (__clk_enable+0x28/0x9c) > [] (__clk_enable) from [] (clk_enable+0x18/0x2c) > [] (clk_enable) from [] (s3c_adc_probe+0x11c/0x18c) > [] (s3c_adc_probe) from [] (platform_drv_probe+0x30/0x78) > [] (platform_drv_probe) from [] (driver_probe_device+0xb0/0x1fc) > [] (driver_probe_device) from [] (__driver_attach+0x68/0x88) > [] (__driver_attach) from [] (bus_for_each_dev+0x70/0x94) > [] (bus_for_each_dev) from [] (bus_add_driver+0xdc/0x1c4) > [] (bus_add_driver) from [] (driver_register+0x9c/0xe0) > [] (driver_register) from [] (adc_init+0x10/0x34) > [] (adc_init) from [] (do_one_initcall+0x110/0x1cc) > [] (do_one_initcall) from [] (kernel_init_freeable+0xf4/0x1ac) > [] (kernel_init_freeable) from [] (kernel_init+0x8/0xe0) > [] (kernel_init) from [] (ret_from_fork+0x14/0x3c) > ---[ end trace f4a1ea39a114fecf ]--- > > Signed-off-by: Sergiy Kibrik Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof