From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hanjun Guo Subject: Re: [PATCH] drivers: acpi: make ACPI_PROCFS_POWER X86 only Date: Sat, 02 May 2015 21:09:35 +0800 Message-ID: <5544CC8F.70203@linaro.org> References: <1430476021-12247-1-git-send-email-lorenzo.pieralisi@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail-pa0-f48.google.com ([209.85.220.48]:35104 "EHLO mail-pa0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750839AbbEBNJn (ORCPT ); Sat, 2 May 2015 09:09:43 -0400 Received: by pabtp1 with SMTP id tp1so117025024pab.2 for ; Sat, 02 May 2015 06:09:43 -0700 (PDT) In-Reply-To: <1430476021-12247-1-git-send-email-lorenzo.pieralisi@arm.com> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Lorenzo Pieralisi , linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org Cc: Lan Tianyu , "Rafael J. Wysocki" On 2015=E5=B9=B405=E6=9C=8801=E6=97=A5 18:27, Lorenzo Pieralisi wrote: > The ACPI procfs power interface is initialized by compilation units > that are only selectable on X86 platforms. Since its usage is > deprecated and it cannot even be used on platforms other than X86 > it should be compiled in only on X86 platforms. > > This patch makes CONFIG_ACPI_PROCFS_POWER dependent on X86, so > that other architectures are prevented from compiling it in for > no purpose. > > Signed-off-by: Lorenzo Pieralisi > Cc: Hanjun Guo > Cc: Lan Tianyu > Cc: Rafael J. Wysocki I think this proc fs was not used for IA64 (it is for server platform) too. Acked-by: Hanjun Guo > --- > Lan, Rafael, > > I do not see any reason why this option is allowed to be selected > on platforms other than X86, so let's make it X86 only. Please let > me know what you think, thanks. > > Lorenzo > > drivers/acpi/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig > index ab2cbb5..16da185 100644 > --- a/drivers/acpi/Kconfig > +++ b/drivers/acpi/Kconfig > @@ -62,7 +62,7 @@ config ACPI_SLEEP > > config ACPI_PROCFS_POWER > bool "Deprecated power /proc/acpi directories" > - depends on PROC_FS > + depends on X86 && PROC_FS > help > For backwards compatibility, this option allows > deprecated power /proc/acpi/ directories to exist, even w= hen > -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752072AbbEBNJr (ORCPT ); Sat, 2 May 2015 09:09:47 -0400 Received: from mail-pd0-f178.google.com ([209.85.192.178]:33041 "EHLO mail-pd0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751281AbbEBNJn (ORCPT ); Sat, 2 May 2015 09:09:43 -0400 Message-ID: <5544CC8F.70203@linaro.org> Date: Sat, 02 May 2015 21:09:35 +0800 From: Hanjun Guo User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Lorenzo Pieralisi , linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org CC: Lan Tianyu , "Rafael J. Wysocki" Subject: Re: [PATCH] drivers: acpi: make ACPI_PROCFS_POWER X86 only References: <1430476021-12247-1-git-send-email-lorenzo.pieralisi@arm.com> In-Reply-To: <1430476021-12247-1-git-send-email-lorenzo.pieralisi@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2015年05月01日 18:27, Lorenzo Pieralisi wrote: > The ACPI procfs power interface is initialized by compilation units > that are only selectable on X86 platforms. Since its usage is > deprecated and it cannot even be used on platforms other than X86 > it should be compiled in only on X86 platforms. > > This patch makes CONFIG_ACPI_PROCFS_POWER dependent on X86, so > that other architectures are prevented from compiling it in for > no purpose. > > Signed-off-by: Lorenzo Pieralisi > Cc: Hanjun Guo > Cc: Lan Tianyu > Cc: Rafael J. Wysocki I think this proc fs was not used for IA64 (it is for server platform) too. Acked-by: Hanjun Guo > --- > Lan, Rafael, > > I do not see any reason why this option is allowed to be selected > on platforms other than X86, so let's make it X86 only. Please let > me know what you think, thanks. > > Lorenzo > > drivers/acpi/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig > index ab2cbb5..16da185 100644 > --- a/drivers/acpi/Kconfig > +++ b/drivers/acpi/Kconfig > @@ -62,7 +62,7 @@ config ACPI_SLEEP > > config ACPI_PROCFS_POWER > bool "Deprecated power /proc/acpi directories" > - depends on PROC_FS > + depends on X86 && PROC_FS > help > For backwards compatibility, this option allows > deprecated power /proc/acpi/ directories to exist, even when >