All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] toolchain/external: better report RPC error for custom toolchains
Date: Sat, 02 May 2015 23:54:33 +0200	[thread overview]
Message-ID: <55454799.9000003@mind.be> (raw)
In-Reply-To: <1430601397-2268-1-git-send-email-yann.morin.1998@free.fr>

On 02/05/15 23:16, Yann E. MORIN wrote:
> Currently, we instruct users to enable/disable BR2_TOOLCHAIN_HAS_NATIVE_RPC
> but that is a blind option. The only option users can set/unset is
> BR2_TOOLCHAIN_EXTERNAL_INET_RPC.
> 
> Use that in the error message.
> 
> Notes: the only way for this message to appear is for a custom external
> toolchain, either downloaded or pre-installed, so even though we check
> the vailidity of the toolchain with BR2_TOOLCHAIN_HAS_NATIVE_RPC, we do
      validity

> report on BR2_TOOLCHAIN_EXTERNAL_INET_RPC.
> 
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>

> ---
>  toolchain/helpers.mk | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/toolchain/helpers.mk b/toolchain/helpers.mk
> index cb3b61a..30eb065 100644
> --- a/toolchain/helpers.mk
> +++ b/toolchain/helpers.mk
> @@ -197,11 +197,11 @@ check_glibc_feature = \
>  check_glibc_rpc_feature = \
>  	IS_IN_LIBC=`test -f $(1)/usr/include/rpc/rpc.h && echo y` ; \
>  	if [ "$(BR2_TOOLCHAIN_HAS_NATIVE_RPC)" != "y" -a "$${IS_IN_LIBC}" = "y" ] ; then \
> -		echo "RPC support available in C library, please enable BR2_TOOLCHAIN_HAS_NATIVE_RPC" ; \
> +		echo "RPC support available in C library, please enable BR2_TOOLCHAIN_EXTERNAL_INET_RPC" ; \
>  		exit 1 ; \
>  	fi ; \
>  	if [ "$(BR2_TOOLCHAIN_HAS_NATIVE_RPC)" = "y" -a "$${IS_IN_LIBC}" != "y" ] ; then \
> -		echo "RPC support not available in C library, please disable BR2_TOOLCHAIN_HAS_NATIVE_RPC" ; \
> +		echo "RPC support not available in C library, please disable BR2_TOOLCHAIN_EXTERNAL_INET_RPC" ; \
>  		exit 1 ; \
>  	fi
>  
> 


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

      reply	other threads:[~2015-05-02 21:54 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-02 21:16 [Buildroot] [PATCH] toolchain/external: better report RPC error for custom toolchains Yann E. MORIN
2015-05-02 21:54 ` Arnout Vandecappelle [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55454799.9000003@mind.be \
    --to=arnout@mind.be \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.