Re: [PATCH 1/1 linux-next] affs: add default case in switch

[Richard Weinberger <richard@nod.at>]

Am 03.05.2015 um 20:38 schrieb Fabian Frederick:
> 
> 
>> On 03 May 2015 at 20:23 Richard Weinberger <richard@nod.at> wrote:
>>
>>
>> Am 03.05.2015 um 20:15 schrieb Fabian Frederick:
>>>> If the code can be reached you need to take a proper action of not the
>>>> warning is bogus.
>>>
>>> As far as I understand, switch in affs_lookup() only updates inode number
>>> when
>>> it's a link so we can simply add default:break to silence gcc warning or
>>> replace
>>> by if().
>>
>> Does the warning trigger with our default set of compiler warnings?
>> Not all gcc warnings are useful. :)
> Only with W=123
> 
>>
>>> affs_iget() switch on the other hand applies to any type of file.
>>> Maybe we could add default: BUG() to avoid working on bad inode ?
>>
>> Or cancel the operation and return -EIO to userspace.
> Ok, thanks, I'll send another version :)

As the warning happens only with W=123 I'd ignore it. :)

Thanks,
//richard