All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Weinberger <richard@nod.at>
To: Simon Glass <sjg@chromium.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Doug Anderson <dianders@chromium.org>
Subject: Re: [PATCH 1/3] Add patman patch automation script
Date: Sun, 03 May 2015 22:43:59 +0200	[thread overview]
Message-ID: <5546888F.2050800@nod.at> (raw)
In-Reply-To: <CAPnjgZ1ZexA5S5VOOumz+GFAwFHBeb2qu12hrwbQDqdWaRjqLw@mail.gmail.com>

Am 03.05.2015 um 22:40 schrieb Simon Glass:
>> But I don't think it makes much sense to carry it with the Linux kernel tree.
>> Other projects can also use it and it does not seem to be very Linux kernel
>> specific.
>> git, quilt and other great tools also have their own repositories.
> 
> My reasoning is that:
> 
> - more will find it / use it if it is in-tree
> - it avoids installation and old-version problems (e.g. I suppose this
> is why the device tree compiler is built-in)
> - it is somewhat Linux-specific (e.g. uses get_maintainers,
> checkpatch.pl) and can break if checkpatch.pl if the wrong version
> (e.g. you check out and send patches from an older tree)
> - it could be built into the Linux workflow [1] and might thereby
> reduce the amount of confusion and errors (did you run checkpatch?,
> your change log is in the wrong place, you forgot to add your
> sign-off, etc.)

If we'd follow these arguments we'd have to move the whole GNU into the
kernel tree. ;-)
checkpatch.pl and get_maintainers.pl are not really a show-stopper.
Other projects are using them too. You can make them also configurable.
i.e. check_script and get_maintaner_script.

Thanks,
//richard

  reply	other threads:[~2015-05-03 20:44 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-03 18:29 [PATCH 0/3] Add a tool to simplify patch checking and posting (patman) Simon Glass
2015-05-03 18:29 ` [PATCH 1/3] Add patman patch automation script Simon Glass
2015-05-03 19:16   ` Richard Weinberger
2015-05-03 19:54     ` Simon Glass
2015-05-03 20:13       ` Richard Weinberger
2015-05-03 20:40         ` Simon Glass
2015-05-03 20:43           ` Richard Weinberger [this message]
2015-05-03 21:43             ` Simon Glass
2015-05-03 18:29 ` [PATCH 2/3] Add tests for patman Simon Glass
2015-05-03 18:29 ` [PATCH 3/3] Add documentation " Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5546888F.2050800@nod.at \
    --to=richard@nod.at \
    --cc=dianders@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sjg@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.