Re: [PATCH 01/13] net: phy: Support Marvell 88E1318S PHY

[Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>]

On 03.05.2015 11:50, Sebastian Hesselbarth wrote:
> On 02.05.2015 22:28, Ezequiel Garcia wrote:
>> On 05/02/2015 01:53 PM, Ezequiel Garcia wrote:
>>> On 04/09/2015 10:03 PM, Sebastian Hesselbarth wrote:
>>>> This adds support for the Marvell 88E1318S Gigabit Ethernet PHY.
>>>>
>>>> Signed-off-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
> [...]
>>>
>>> With this commit, the Openblocks A6 PHY is not brought up, and so
>>> network is broken.
>>>
>>> I'll look into it (unless you have an idea),
>>>
>>
>> Hm.. the devicetree needs to specify the phy-mode:
>>
>> diff --git a/dts/src/arm/kirkwood-openblocks_a6.dts
>> b/dts/src/arm/kirkwood-openblocks_a6.dts
>> index fb9dc22..c53e37f 100644
>> --- a/dts/src/arm/kirkwood-openblocks_a6.dts
>> +++ b/dts/src/arm/kirkwood-openblocks_a6.dts
>> @@ -171,6 +171,7 @@
>>   &eth0 {
>>          status = "okay";
>>          ethernet0-port@0 {
>> +               phy-mode = "rgmii-id";
>>                  phy-handle = <&ethphy0>;
>>          };
>>   };
>>
>> However, network works really crappy even after this change (either in
>> barebox or in Linux).
>
> Ezequiel,
>
> RGMII phy-mode would have been my first guess.
>
> Can you define "crappy"  with respect to ethernet?
>
> The patch doesn't do anything different than the linux marvell phy
> code would do. Do you have access to A6's u-boot source and can match
> up the PHY init sequence?

Maybe we need some 1V8 RGMII setup for A6 too?

https://lkml.org/lkml/2015/5/3/159

It also uses 88e1318 PHY but on A370 and on Kirkwood we also have
IO Configuration 0 register 0xf10100e0, bit 7:
RGMII PADS Voltage, 0 = 3V3, 1 = 1V8

Maybe you double-check it on u-boot first?

Sebastian

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox