From: Jaehoon Chung <jh80.chung@samsung.com>
To: Zhangfei Gao <zhangfei.gao@linaro.org>,
Ulf Hansson <ulf.hansson@linaro.org>
Cc: linux-mmc@vger.kernel.org, Fei Wang <w.f@huawei.com>,
CPGS <cpgs@samsung.com>
Subject: Re: [PATCH] mmc: dw_mmc: init desc in dw_mci_idmac_init
Date: Mon, 04 May 2015 09:07:00 +0900 [thread overview]
Message-ID: <5546B824.80203@samsung.com> (raw)
In-Reply-To: <1430403388-4184-1-git-send-email-zhangfei.gao@linaro.org>
Hi, Zhangfei.
Will apply this patch at my dw-mmc tree.
Thanks!
Best Regards,
Jaehoon Chung
On 04/30/2015 11:16 PM, Zhangfei Gao wrote:
> Set 0 to des1 in 32bit case.
> Otherwise the random value of des1 will be used in
> dw_mci_translate_sglist: IDMAC_SET_BUFFER1_SIZE(desc, length)
>
> Signed-off-by: Fei Wang <w.f@huawei.com>
> Signed-off-by: Zhangfei Gao <zhangfei.gao@linaro.org>
> ---
> drivers/mmc/host/dw_mmc.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
> index 241454f..488a8af 100644
> --- a/drivers/mmc/host/dw_mmc.c
> +++ b/drivers/mmc/host/dw_mmc.c
> @@ -589,9 +589,11 @@ static int dw_mci_idmac_init(struct dw_mci *host)
> host->ring_size = PAGE_SIZE / sizeof(struct idmac_desc);
>
> /* Forward link the descriptor list */
> - for (i = 0, p = host->sg_cpu; i < host->ring_size - 1; i++, p++)
> + for (i = 0, p = host->sg_cpu; i < host->ring_size - 1; i++, p++) {
> p->des3 = cpu_to_le32(host->sg_dma +
> (sizeof(struct idmac_desc) * (i + 1)));
> + p->des1 = 0;
> + }
>
> /* Set the last descriptor as the end-of-ring descriptor */
> p->des3 = cpu_to_le32(host->sg_dma);
>
prev parent reply other threads:[~2015-05-04 0:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-29 13:31 [PATCH] mmc: dw_mmc: init desc in dw_mci_idmac_init Zhangfei Gao
2015-04-30 8:01 ` Jaehoon Chung
2015-04-30 8:37 ` zhangfei
[not found] ` <CAELcNGSWV_EVECekLcnP=x992XO8=164bUcA=P=G28Ee0J6myg@mail.gmail.com>
2015-04-30 14:13 ` Zhangfei Gao
2015-04-30 14:16 ` Zhangfei Gao
2015-05-04 0:07 ` Jaehoon Chung [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5546B824.80203@samsung.com \
--to=jh80.chung@samsung.com \
--cc=cpgs@samsung.com \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=w.f@huawei.com \
--cc=zhangfei.gao@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.