All of lore.kernel.org
 help / color / mirror / Atom feed
From: Robert Yang <liezhi.yang@windriver.com>
To: "Burton, Ross" <ross.burton@intel.com>
Cc: OE-core <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 1/1] libxml2: fix python path and add libxml2-python
Date: Mon, 4 May 2015 11:11:35 +0800	[thread overview]
Message-ID: <5546E367.60301@windriver.com> (raw)
In-Reply-To: <CAJTo0LZcADEC1Y3rjcEs61+S8jSe9C+28sT0r2xvGpSO5vR3Xw@mail.gmail.com>



On 05/01/2015 11:46 PM, Burton, Ross wrote:
> buildhistory says:
>
> packages/corei7-64-poky-linux/libxml2/libxml2: RDEPENDS: added "python-core"
>
> Why does the library package gain a dependency on python?

Sorry, I updated the patch a little, it was because of this line:

PACKAGECONFIG[python] = 
"--with-python=${PYTHON},--without-python,python,python-core"

The python-core should not be there, but should be:

RDEPENDS_${PN}-python += "python-core".

I updated it in the repo:

   git://git.openembedded.org/openembedded-core-contrib rbt/libxml2



diff --git a/meta/recipes-core/libxml/libxml2.inc 
b/meta/recipes-core/libxml/libxml2.inc
index 1314bbf..d337bec 100644
--- a/meta/recipes-core/libxml/libxml2.inc
+++ b/meta/recipes-core/libxml/libxml2.inc
@@ -9,8 +9,6 @@ LIC_FILES_CHKSUM = 
"file://Copyright;md5=2044417e2e5006b65a8b9067b683fcf1 \
 
file://list.c;beginline=4;endline=13;md5=cdbfa3dee51c099edb04e39f762ee907 \
 
file://trio.c;beginline=5;endline=14;md5=6c025753c86d958722ec76e94cae932e"

-DEPENDS_class-nativesdk = "nativesdk-python"
-DEPENDS_class-native = "python-native"
  DEPENDS =+ "zlib"

  SRC_URI = "ftp://xmlsoft.org/libxml2/libxml2-${PV}.tar.gz;name=libtar \
@@ -30,6 +28,8 @@ inherit autotools pkgconfig binconfig-disabled pythonnative ptest

  RDEPENDS_${PN}-ptest += "python-core"

+RDEPENDS_${PN}-python += "python-core"
+
  RDEPENDS_${PN}-ptest_append_libc-glibc += "glibc-gconv-ebcdic-us 
glibc-gconv-ibm1141"

  # We don't DEPEND on binutils for ansidecl.h so ensure we don't use the header
@@ -37,16 +37,16 @@ do_configure_prepend () {
         sed -i -e '/.*ansidecl.h.*/d' ${S}/configure.ac
  }
  -do_configure_prepend_class-nativesdk () {
-       # Ensure we get the correct site-packages path
-       export PYTHON_SITE_PACKAGES="${PYTHON_SITEPACKAGES_DIR}"
-}
+export PYTHON_SITE_PACKAGES="${PYTHON_SITEPACKAGES_DIR}"
+
+PACKAGECONFIG ??= "python"

+PACKAGECONFIG[python] = "--with-python=${PYTHON},--without-python,python"
  # WARNING: zlib is require for RPM use
-EXTRA_OECONF = "--without-python --without-debug --without-legacy 
--with-catalog --without-docbook --with-c14n --without-lzma --with-fexceptions"
-EXTRA_OECONF_class-native = "--with-python=${STAGING_BINDIR}/python 
--without-legacy --without-docbook --with-c14n --without-lzma --with-zlib"
-EXTRA_OECONF_class-nativesdk = "--with-python=${STAGING_BINDIR}/python 
--without-legacy --without-docbook --with-c14n --without-lzma --with-zlib"
-EXTRA_OECONF_linuxstdbase = "--without-python --with-debug --with-legacy 
--with-docbook --with-c14n --without-lzma --with-zlib"
+EXTRA_OECONF = "--without-debug --without-legacy --with-catalog 
--without-docbook --with-c14n --without-lzma --with-fexceptions"
+EXTRA_OECONF_class-native = "--without-legacy --without-docbook --with-c14n 
--without-lzma --with-zlib"
+EXTRA_OECONF_class-nativesdk = "--without-legacy --without-docbook --with-c14n 
--without-lzma --with-zlib"
+EXTRA_OECONF_linuxstdbase = "--with-debug --with-legacy --with-docbook 
--with-c14n --without-lzma --with-zlib"

  # required for pythong binding
  export HOST_SYS

// Robert

>
> Ross
>
> On 29 April 2015 at 08:26, Robert Yang <liezhi.yang@windriver.com
> <mailto:liezhi.yang@windriver.com>> wrote:
>
>     We have libxml2-python for native and nativesdk, but don't have it for
>     target, and can't find the reason from the git log, libxml2-python is
>     widely used, after looked into it's configure.in <http://configure.in>, we
>     can add it
>     by PACKAGECONFIG.
>
>     The previous --with-python=${STAGING_BINDIR}/python is incorrect, it
>     acted as work becase it's conigure can check automatically, python is in
>     ${STAGING_BINDIR_NATIVE}/${PYTHON_PN}-native/${PYTHON_PN}, as known as
>     ${PYTHON}.
>
>     Add python to PACKAGECONFIG, since createrepo rdepends on
>     libxml2-python, otherwise the target createrepo can't work.
>
>     Signed-off-by: Robert Yang <liezhi.yang@windriver.com
>     <mailto:liezhi.yang@windriver.com>>
>     ---
>       meta/recipes-core/libxml/libxml2.inc |   18 ++++++++----------
>       1 file changed, 8 insertions(+), 10 deletions(-)
>
>     diff --git a/meta/recipes-core/libxml/libxml2.inc
>     b/meta/recipes-core/libxml/libxml2.inc
>     index 1314bbf..4886705 100644
>     --- a/meta/recipes-core/libxml/libxml2.inc
>     +++ b/meta/recipes-core/libxml/libxml2.inc
>     @@ -9,8 +9,6 @@ LIC_FILES_CHKSUM =
>     "file://Copyright;md5=2044417e2e5006b65a8b9067b683fcf1 \
>
>       file://list.c;beginline=4;endline=13;md5=cdbfa3dee51c099edb04e39f762ee907 \
>
>       file://trio.c;beginline=5;endline=14;md5=6c025753c86d958722ec76e94cae932e"
>
>     -DEPENDS_class-nativesdk = "nativesdk-python"
>     -DEPENDS_class-native = "python-native"
>       DEPENDS =+ "zlib"
>
>       SRC_URI = "ftp://xmlsoft.org/libxml2/libxml2-${PV}.tar.gz;name=libtar \
>     @@ -37,16 +35,16 @@ do_configure_prepend () {
>              sed -i -e '/.*ansidecl.h.*/d' ${S}/configure.ac <http://configure.ac>
>       }
>
>     -do_configure_prepend_class-nativesdk () {
>     -       # Ensure we get the correct site-packages path
>     -       export PYTHON_SITE_PACKAGES="${PYTHON_SITEPACKAGES_DIR}"
>     -}
>     +export PYTHON_SITE_PACKAGES="${PYTHON_SITEPACKAGES_DIR}"
>     +
>     +PACKAGECONFIG ??= "python"
>
>     +PACKAGECONFIG[python] =
>     "--with-python=${PYTHON},--without-python,python,python-core"
>       # WARNING: zlib is require for RPM use
>     -EXTRA_OECONF = "--without-python --without-debug --without-legacy
>     --with-catalog --without-docbook --with-c14n --without-lzma --with-fexceptions"
>     -EXTRA_OECONF_class-native = "--with-python=${STAGING_BINDIR}/python
>     --without-legacy --without-docbook --with-c14n --without-lzma --with-zlib"
>     -EXTRA_OECONF_class-nativesdk = "--with-python=${STAGING_BINDIR}/python
>     --without-legacy --without-docbook --with-c14n --without-lzma --with-zlib"
>     -EXTRA_OECONF_linuxstdbase = "--without-python --with-debug --with-legacy
>     --with-docbook --with-c14n --without-lzma --with-zlib"
>     +EXTRA_OECONF = "--without-debug --without-legacy --with-catalog
>     --without-docbook --with-c14n --without-lzma --with-fexceptions"
>     +EXTRA_OECONF_class-native = "--without-legacy --without-docbook --with-c14n
>     --without-lzma --with-zlib"
>     +EXTRA_OECONF_class-nativesdk = "--without-legacy --without-docbook
>     --with-c14n --without-lzma --with-zlib"
>     +EXTRA_OECONF_linuxstdbase = "--with-debug --with-legacy --with-docbook
>     --with-c14n --without-lzma --with-zlib"
>
>       # required for pythong binding
>       export HOST_SYS
>     --
>     1.7.9.5
>
>     --
>     _______________________________________________
>     Openembedded-core mailing list
>     Openembedded-core@lists.openembedded.org
>     <mailto:Openembedded-core@lists.openembedded.org>
>     http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
>


  reply	other threads:[~2015-05-04  3:11 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-29  7:26 [PATCH 0/1] libxml2: fix python path and add libxml2-python Robert Yang
2015-04-29  7:26 ` [PATCH 1/1] " Robert Yang
2015-05-01 15:46   ` Burton, Ross
2015-05-04  3:11     ` Robert Yang [this message]
  -- strict thread matches above, loose matches on Subject: below --
2014-09-16  1:48 [PATCH 0/1 V2] " Robert Yang
2014-09-16  1:48 ` [PATCH 1/1] " Robert Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5546E367.60301@windriver.com \
    --to=liezhi.yang@windriver.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=ross.burton@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.