From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752052AbbEDFhh (ORCPT ); Mon, 4 May 2015 01:37:37 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:33281 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750975AbbEDFh2 (ORCPT ); Mon, 4 May 2015 01:37:28 -0400 X-AuditID: cbfee68e-f79c56d000006efb-07-554705911c24 Message-id: <55470591.7000600@samsung.com> Date: Mon, 04 May 2015 14:37:21 +0900 From: Chanwoo Choi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130106 Thunderbird/17.0.2 MIME-version: 1.0 To: Krzysztof Kozlowski Cc: linux-kernel , jaewon02.kim@samsung.com, "myungjoo.ham@samsung.com" , Kyungmin Park Subject: Re: [PATCH 0/4] extcon: Modify the name of unused external connector References: <1430137889-22771-1-git-send-email-cw00.choi@samsung.com> <553F01D3.5040305@samsung.com> <55418F0B.5090404@samsung.com> In-reply-to: <55418F0B.5090404@samsung.com> Content-type: text/plain; charset=UTF-8 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupkkeLIzCtJLcpLzFFi42JZI2JSrDuR1T3UYF6ThsWOhiOsFq9fGFqc bXrDbnF51xw2i9uNK9gcWD36tqxi9Pi8SS6AKYrLJiU1J7MstUjfLoErY9/2AywFj8QrDi8u bGDsEe5i5OCQEDCR+Pu5touRE8gUk7hwbz1bFyMXh5DAUkaJeX/vMkIkgGqmn2eESExnlPi3 YzIrhPOAUWLblkusIFW8AloSUzb0M4NMZRFQlTj6MQEkzAYU3v/iBhuILSoQJrFy+hUWiHJB iR+T74HZIgKGEgd3b2cCmckssB5o5s/VYAlhAV+JfWu/sEAsO8co0Tz7LtgkTgFtidbGaWBF zALqEpPmLWKGsOUlNq95ywzSICGwjF3i8LmvYA0sAgIS3yYfYoH4WVZi0wFmiNckJQ6uuMEy gVFsFpKjZiEZOwvJ2AWMzKsYRVMLkguKk9KLjPSKE3OLS/PS9ZLzczcxAmPo9L9nfTsYbx6w PsQowMGoxMN7YpVbqBBrYllxZe4hRlOgKyYyS4km5wMjNa8k3tDYzMjC1MTU2Mjc0kxJnDdB 6mewkEB6YklqdmpqQWpRfFFpTmrxIUYmDk6pBkZb+U3OnpOMnti2zVHaX+ZtUrT/vNiNjQ7B e4JLz3i29EVf+WrlPEF6sutDrxW3tX6tStP++Fmft/shc7FWtd2yMNtXMj83NrjfvxmdMolv 45f79hZt07fJzoi4daLHJ/XBs5jwAuXETume2W9159rmTq6xfnVa60XDUfNYjRTpqZMu7rIK uaXEUpyRaKjFXFScCACRdxZXnAIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrCIsWRmVeSWpSXmKPExsVy+t9jQd2JrO6hBpc2KFvsaDjCavH6haHF 2aY37BaXd81hs7jduILNgdWjb8sqRo/Pm+QCmKIaGG0yUhNTUosUUvOS81My89JtlbyD453j Tc0MDHUNLS3MlRTyEnNTbZVcfAJ03TJzgLYpKZQl5pQChQISi4uV9O0wTQgNcdO1gGmM0PUN CYLrMTJAAwlrGDP2bT/AUvBIvOLw4sIGxh7hLkZODgkBE4m/088zQthiEhfurWfrYuTiEBKY zijxb8dkVgjnAaPEti2XWEGqeAW0JKZs6GfuYuTgYBFQlTj6MQEkzAYU3v/iBhuILSoQJrFy +hUWiHJBiR+T74HZIgKGEgd3b2cCmckssB5o5s/VYAlhAV+JfWu/sEAsO8co0Tz7LtgkTgFt idbGaWBFzALqEpPmLWKGsOUlNq95yzyBUWAWkiWzkJTNQlK2gJF5FaNoakFyQXFSeq6hXnFi bnFpXrpecn7uJkZwjD6T2sG4ssHiEKMAB6MSD++JVW6hQqyJZcWVuYcYJTiYlUR4n3wECvGm JFZWpRblxxeV5qQWH2I0BQbBRGYp0eR8YPrIK4k3NDYxM7I0Mje0MDI2VxLnnaMrFyokkJ5Y kpqdmlqQWgTTx8TBKQWMglU3J/9VZL3ybcObK98fms70y7XkmX8mSEl8/sO16lu/fJ/0+Rm3 1HWLea0zo2R8rsx2O6ycOM9N6GJ13pvG9ffjPodU/L1uxc8bVy5V/UfCplZyqaV7gmm//eea d5e8Uq/eVc2UVNnalKzUsNVgT16+mI1ik3q53H6x2Gu1+dapHEn8kbOUWIozEg21mIuKEwHt nPMs5wIAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/30/2015 11:10 AM, Krzysztof Kozlowski wrote: > On 28.04.2015 17:40, Chanwoo Choi wrote: >> On Tue, Apr 28, 2015 at 12:43 PM, Krzysztof Kozlowski >> wrote: >>> On 27.04.2015 21:31, Chanwoo Choi wrote: >>>> >>>> This patchset alter the unused name of external connector (jig/dock/MHL) >>>> as >>>> following. The name of jig cable and dock device include the non-standard >>>> H/W >>>> information. On user-space side, this information are not necessary. The >>>> extcon >>>> core will support the other method to inform the specific H/W information >>>> to >>>> kernel device driver and framework. For example, extcon core have the plan >>>> to add >>>> the notifier chain for USB ID/VBUS pin state. If extcon consumer (kernel >>>> device >>>> driver and framework) use the notifer chain for USB ID/VBUS, they can get >>>> the >>>> state of both JIG and USB when JIG-USB-ON cable is attached. >>>> >>>> And last patch removes the unused 'num_cables' filed on extcon-adc-jack.c. >>>> >>>> 1. jig cable name >>>> - JIG-USB-ON -->| >>>> - JIG-USB-OFF -->| >>>> - JIG-UART-ON -->| >>>> - JIG-UART-OFF -->|--> JIG >>>> >>>> 2. dock device name >>>> - Dock-Smart -->| >>>> - Dock-Desk -->| >>>> - Dock-Audio -->| >>>> - Dock-Card -->|--> DOCK >>>> >>>> 3. MHL-TA cable name >>>> - MHL-TA -> TA >>> >>> >>> Hi, >>> >>> That makes sense but isn't such change a break of interface with user-space? >>> The user-space may expect Dock-xxx for Dock. >> >> I guess it's possible. But, the "Dock-{Smart|Desk|Audio}" device name are not >> standard. Their name are only used for Samsung Galaxy S3 (releaesd 3.0 >> kernel) and it is not for mainline kernel. >> >> So, I want to make the standard cable name for mainline kernel and user-space. >> The extcon driver will send the event of 'dock' device with specific >> external connector which is connected to 'dock' device. >> >> For example, Dock-Smart means the Dock device with MHL cable. When >> Dock-Smart is attached, extcon driver will send the two external >> connector state of >> both 'DOCK' and 'MHL'. So, the user-space process will detect the kind of dock >> by catching both 'DOCK' and 'MHL' uevent. > > Okay, one more concern - for Dock-Smart the extcon will send two consecutive events (first DOCK, then MHL). So to distinguish this from two separate connections of Dock and MHL (user first connects some Dock, disconnects, connects MHL), the driver always has to call extcon_set_cable_state(edev, "Dock", false) after disconnection. > > Without the "disconnect" state this case would mean for userspace "Dock+MHL". > > This looks like an important part of API for extcon and for driver implementations. So it should be documented somewhere? There is no document about it. I'll send other patch for the sequence of two events as following: - attached 1. DOCK is attached 2. MHL is attached - detached 1. MHL is detached 2. DOCK is detached Thanks, Chanwoo Choi