Re: [Qemu-devel] .gitignore contains .c and .h ?

["Guillaume Le Louët" <guillaume.lelouet@gmail.com>]

You're right, I noticed that compiling with make was removing my 
modifications.
I ended up modifying the qapi-schema.json .

May I advise to move the generated .c and .h files into a generated/ 
folder ?

Thank you Thomas.

Le 04/05/2015 13:01, Thomas Huth a écrit :
> On Mon, 04 May 2015 09:47:11 +0200
> Guillaume Le Louët <guillaume.lelouet@gmail.com> wrote:
>
>> Hello.
>>
>> The .gitignore in the master branch contains the following lines :
>> /qapi-types.[ch]
>> /qapi-visit.[ch]
>> /qapi-event.[ch]
>>
>> Why is it so ? Are they generated automatically each time I compile the
>> project ?
>> I am modifying qapi-types.h and qapi-types.c , am I doing wrong ?
> Yes, they are created automatically and you should not edit them
> manually. Just have a look at the main Makefile:
>
> qapi-modules = $(SRC_PATH)/qapi-schema.json $(SRC_PATH)/qapi/common.json \
>                 $(SRC_PATH)/qapi/block.json $(SRC_PATH)/qapi/block-core.json \
>                 $(SRC_PATH)/qapi/event.json
>
> qapi-types.c qapi-types.h :\
> $(qapi-modules) $(SRC_PATH)/scripts/qapi-types.py $(qapi-py)
>          $(call quiet-command,$(PYTHON) $(SRC_PATH)/scripts/qapi-types.py \
>                  $(gen-out-type) -o "." -b -i $<, \
>                  "  GEN   $@")
>
> So if you want to change something in this area, you likely have to
> touch the *.json files instead.
>
>   Thomas