From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [RFC PATCH v2 13/22] xen/arm: its: Add virtual ITS command support Date: Mon, 4 May 2015 14:04:50 +0100 Message-ID: <55476E72.2010003@citrix.com> References: <1426775889-29442-1-git-send-email-vijay.kilari@gmail.com> <553F6271.4010308@citrix.com> <553FB23F.7090200@citrix.com> <5540C6D5.9020400@citrix.com> <5540DE16.4090900@citrix.com> <55411D1F.4090308@citrix.com> <5541FF51.6060907@citrix.com> <55423C44.6070702@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Vijay Kilari Cc: Ian Campbell , Stefano Stabellini , Prasun Kapoor , Vijaya Kumar K , Julien Grall , Tim Deegan , "xen-devel@lists.xen.org" , Stefano Stabellini , manish.jaggi@caviumnetworks.com List-Id: xen-devel@lists.xenproject.org On 04/05/2015 13:58, Vijay Kilari wrote: > On Thu, Apr 30, 2015 at 7:59 PM, Julien Grall wrote: >> Hi, >> >> On 30/04/15 14:47, Stefano Stabellini wrote: >>>>>> >>>>>> If the devid is not within this range, the ITS won't recognize the value and >>>>>> won't be able to send the interrupt. >>>>>> >>>>>> So this is clearly not the right value. >>>>> >>>>> Sure, in that case the maximum value allowed by GITS_TYPER.Devbits. >>>>> Vijay, what is the value of GITS_TYPER.Devbits on your platform? >>>> >>>> It is 21 bits >>> >>> I would imagine that 21 bits would be plenty to find an unused devid. >>> >>> Alternatively we could use an inexistent function of a real device, such >>> as 00:00.1 (function 1 of the host bridge). >> >> As discussed IRL, this idea sounds good to me. >> >> Although I would be happy with any other way which ensure the devid is free. > > Has prototyped with 00.00.1 as device id. But I see that Dom0 boot is > slow compared to polling mode. This could be because Dom0 has to keep > trapping on creader to check if creader is updated or not. How did you implement the interrupt mode? Could it be improve? Regards, -- Julien Grall