From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrzej Hajda Subject: Re: [PATCH] drm/exynos: Fix build breakage on !DRM_EXYNOS_FIMD Date: Mon, 04 May 2015 15:15:13 +0200 Message-ID: <554770E1.2000401@samsung.com> References: <1430539706-2945-1-git-send-email-k.kozlowski.k@gmail.com> <55472339.8040408@samsung.com> <5547696D.8000300@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-reply-to: <5547696D.8000300@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Krzysztof Kozlowski , Daniel Stone Cc: linux-samsung-soc , Seung-Woo Kim , Linux Kernel Mailing List , dri-devel , Kyungmin Park , Kukjin Kim , "linux-arm-kernel@lists.infradead.org" List-Id: linux-samsung-soc@vger.kernel.org SGksCgoKT24gMDUvMDQvMjAxNSAwMjo0MyBQTSwgS3J6eXN6dG9mIEtvemxvd3NraSB3cm90ZToK PiAyMDE1LTA1LTA0IDIwOjM0IEdNVCswOTowMCBEYW5pZWwgU3RvbmUgPGRhbmllbEBmb29pc2hi YXIub3JnPjoKPj4gSGksCj4+Cj4+IE9uIDQgTWF5IDIwMTUgYXQgMDg6NDMsIElua2kgRGFlIDxp bmtpLmRhZUBzYW1zdW5nLmNvbT4gd3JvdGU6Cj4+PiBPbiAyMDE164WEIDA17JuUIDAy7J28IDEz OjA4LCBLcnp5c3p0b2YgS296bG93c2tpIHdyb3RlOgo+Pj4+IFNlbGVjdGluZyBDT05GSUdfRkJf UzNDIGRpc2FibGVzIENPTkZJR19EUk1fRVhZTk9TX0ZJTUQgbGVhZGluZyB0byBidWlsZAo+Pj4+ IGVycm9yOgo+Pj4KPj4+IE5vLCBlRFAgaGFzIG5vIGFueSBkZXBlbmRlbmN5IG9mIEZJTUQgYnV0 IERFQ09OLiBKdXN0IGFkZCBkZXBlbmRlbmN5Cj4+PiBjb2RlIGxpa2UgYmVsb3csCj4+Pgo+Pj4g IGNvbmZpZyBEUk1fRVhZTk9TN19ERUNPTgo+Pj4gICAgICAgICBib29sICJFeHlub3MgRFJNIERF Q09OIgo+Pj4gLSAgICAgICBkZXBlbmRzIG9uIERSTV9FWFlOT1MKPj4+ICsgICAgICAgZGVwZW5k cyBvbiBEUk1fRVhZTk9TICYmICFGQl9TM0MKPiAKPiBBY3R1YWxseSBteSBjb21taXQgbWVzc2Fn ZSB3YXMgbm90IGRldGFpbGVkIGVub3VnaC4gVGhlIEZCX1MzQyBoZXJlCj4gd29uJ3Qgc29sdmUg dGhlIGlzc3VlIGJlY2F1c2UgeW91IG1heToKPiAxLCBkaXNhYmxlIEZJTUQgYW5kIEZCX1MzQywK PiAyLCBlbmFia2UgREVDT04gYW5kIERQLAo+IGFuZCBpdCB3b24ndCBjb21waWxlLgo+IAo+IEN1 cnJlbnRseSB0aGUgRklNRCBtdXN0IGJlIGVuYWJsZWQgaWYgRFJNX0VYWU5PU19EUCBpcyBlbmFi bGVkLgo+IAo+Pgo+PiBCdXQgaXQgZG9lcyBjbGVhcmx5IGFuZCBleHBsaWNpdGx5IGNhbGwgZmlt ZF9kcF9jbG9ja19lbmFibGUgZnJvbQo+PiBleHlub3NfZHBfcG93ZXJve24sZmZ9LiBTbyB0aGUg ZGVwZW5kZW5jeSB5b3UncmUgcHJvcG9zaW5nIHNlZW1zCj4+IGJhY2t3YXJkczogaXQncyBub3Qg YW4gZXhwcmVzc2lvbiBvZiB0aGUgcmVxdWlyZW1lbnRzIG9mIHRoZSBjdXJyZW50Cj4+IGNvZGUg KHRoYXQgRklNRCBEUCBjb2RlIGJlIGF2YWlsYWJsZSwgaS5lLiBDT05GSUdfRFJNX0VYWU5PU19G SU1EIGlzCj4+IHNlbGVjdGVkKSwgYnV0IGFuIGluZGlyZWN0IGV4cHJlc3Npb24gb2YgYW5vdGhl ciBkZXBlbmRlbmN5Cj4+IChDT05GSUdfRkJfUzNDIGRpc2FibGVzIENPTkZJR19EUk1fRVhZTk9T X0ZJTUQsIHNvIGRpc2FibGUKPj4gQ09ORklHX0ZCX1MzQykuCj4+Cj4+IEFkZGl0aW9uYWxseSwg YXMgdGhlIGNhbGwgY29tZXMgZnJvbSBleHlub3NfZHBfY29yZS5jLCB3aGljaCBpcyBidWlsdAo+ PiBieSBDT05GSUdfRFJNX0VYWU5PU19EUCAoYW4gZXhwbGljaXRseSB1c2VyLXNlbGVjdGFibGUg b3B0aW9uKSwgd2h5Cj4+IHNob3VsZG4ndCB0aGUgZGVwZW5kZW5jeSBiZSB0aGVyZT8gQWgsIGJl Y2F1c2UgdGhlIGRlcGVuZGVuY3kgb24gRFAgaXMKPj4gZm9yIChERUNPTiB8fCBGSU1EKSwgYnV0 IGFzIERFQ09OIGRvZXNuJ3QgcHJvdmlkZQo+PiBmaW1kX2RwX2Nsb2NrX2VuYWJsZSgpLCBpdCBk b2Vzbid0IHNlZW0gbGlrZSBpdCB3b3VsZCBjb21waWxlIGlmIHlvdQo+PiBzZWxlY3RlZCBERUNP TiBhbmQgbm90IEZJTUQuCj4+Cj4+IFNvLCBmb3IgbWUsIHRoZSBjbGVhbmVzdCBzb2x1dGlvbiB3 b3VsZCBiZSBjb25maWcgRFJNX0VYWU5PU19EUCBnYWlucwo+PiBhIGhhcmQgZGVwZW5kZW5jeSBv biBEUk1fRVhZTk9TX0ZJTUQsIGF0IGxlYXN0IHVudGlsIGl0IGNhbiBiZSBmaXhlZAo+PiB0byBj b21waWxlIHdpdGhvdXQgRklNRC4KPiAKPiBSaWdodCwgeW91IGNvcnJlY3RseSBwb2ludGVkIGN1 cnJlbnQgZGVwZW5kZW5jaWVzLiBTdGlsbCBpdCBsb29rcyBsaXR0bGUKPiBoYWNreSBiZWNhdXNl IEVYWU5PU19EUCBtYXkgd29yayB3aXRoIEZJTUQgb3IgREVDT04uIAoKQXJlIHlvdSBzdXJlPyBJ IGhhdmUgbm90IHNlZW4gYW55IGNoaXBzZXQgaGF2aW5nIERFQ09OIGFuZCBEUC4gSW4gYWxsCmNo aXBzZXRzIGtub3duIHRvIG1lIERQIGlzIGFsd2F5cyBhY2NvbXBhbmllZCBieSBGSU1ELiBJIGd1 ZXNzIGl0IGNhbgpjaGFuZ2UgaW4gdGhlIGZ1dHVyZSwgYnV0IGZvciBub3cgaGFyZCBkZXBlbmRl bmN5IG9uIEZJTUQgc2VlbXMgdG8gYmUgT0sKLSBpdCBqdXN0IHJlZmxlY3RzIGhhcmR3YXJlIGRl c2lnbi4KT2YgY291cnNlIHRoaXMgaXMganVzdCBteSBodW1ibGUgb3BpbmlvbiA6KQoKUmVnYXJk cwpBbmRyemVqCgpJdCBkb2VzIG5vdCByZWFsbHkKPiBuZWVkIEZJTUQuIFVzaW5nIGlmZGVmcyBp biBoZWFkZXJzIGlzIG5vdCB1bmNvbW1vbiAtIG1hbnkgY29yZQo+IHN1YnN5c3RlbXMgZG8gdGhp cyB0aGF0IHdheSB0byBwcm92aWRlIHN0dWJzLgo+IAo+IFByb2JhYmx5IHRoZSBjbGVhbmVzdCB3 YXkgd291bGQgYmUgdG8gcHJvdmlkZSBieSBGSU1EIGFuZCBERUNPTiBhIGNvbW1vbgo+IGludGVy ZmFjZSBmb3IgRFAgZm9yIHN1Y2ggb3BlcmF0aW9uLCBzb21ldGhpbmcgbGlrZToKPiBzdHJ1Y3Qg ZXh5bm9zX2RybV9jcnRjIHsKPiAJc3RydWN0IGRybV9jcnRjICAgICAgICAgICAgICAgICBiYXNl Owo+IAkuLi4KPiAJdm9pZCAoKmNsb2NrX2VuYWJsZSkoc3RydWN0IGV4eW5vc19kcm1fY3J0YyAq Y3J0YywgYm9vbCBlbmFibGUpCj4gKTsKPiAKPiB3aGljaCwgaWYgbm9uLU5VTEwsIHdpbGwgYmUg Y2FsbGVkIGJ5IGV4eW5vc19kcF9jb3JlLmM6Cj4gc3RhdGljIHZvaWQgZXh5bm9zX2RwX3Bvd2Vy b24oc3RydWN0IGV4eW5vc19kcF9kZXZpY2UgKmRwKQo+IHsKPiAJLi4uCj4gCWlmIChjcnRjLT5j bG9ja19lbmFibGUpCj4gCQljcnRjLT5jbG9ja19lbmFibGUoY3J0YywgdHJ1ZSk7Cj4gfQo+IAo+ IFdoYXQgZG8geW91IHRoaW5rPwo+IAo+IEJlc3QgcmVnYXJkcywKPiBLcnp5c3p0b2YKPiAKCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBt YWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMu ZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: a.hajda@samsung.com (Andrzej Hajda) Date: Mon, 04 May 2015 15:15:13 +0200 Subject: [PATCH] drm/exynos: Fix build breakage on !DRM_EXYNOS_FIMD In-Reply-To: <5547696D.8000300@gmail.com> References: <1430539706-2945-1-git-send-email-k.kozlowski.k@gmail.com> <55472339.8040408@samsung.com> <5547696D.8000300@gmail.com> Message-ID: <554770E1.2000401@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, On 05/04/2015 02:43 PM, Krzysztof Kozlowski wrote: > 2015-05-04 20:34 GMT+09:00 Daniel Stone : >> Hi, >> >> On 4 May 2015 at 08:43, Inki Dae wrote: >>> On 2015? 05? 02? 13:08, Krzysztof Kozlowski wrote: >>>> Selecting CONFIG_FB_S3C disables CONFIG_DRM_EXYNOS_FIMD leading to build >>>> error: >>> >>> No, eDP has no any dependency of FIMD but DECON. Just add dependency >>> code like below, >>> >>> config DRM_EXYNOS7_DECON >>> bool "Exynos DRM DECON" >>> - depends on DRM_EXYNOS >>> + depends on DRM_EXYNOS && !FB_S3C > > Actually my commit message was not detailed enough. The FB_S3C here > won't solve the issue because you may: > 1, disable FIMD and FB_S3C, > 2, enabke DECON and DP, > and it won't compile. > > Currently the FIMD must be enabled if DRM_EXYNOS_DP is enabled. > >> >> But it does clearly and explicitly call fimd_dp_clock_enable from >> exynos_dp_powero{n,ff}. So the dependency you're proposing seems >> backwards: it's not an expression of the requirements of the current >> code (that FIMD DP code be available, i.e. CONFIG_DRM_EXYNOS_FIMD is >> selected), but an indirect expression of another dependency >> (CONFIG_FB_S3C disables CONFIG_DRM_EXYNOS_FIMD, so disable >> CONFIG_FB_S3C). >> >> Additionally, as the call comes from exynos_dp_core.c, which is built >> by CONFIG_DRM_EXYNOS_DP (an explicitly user-selectable option), why >> shouldn't the dependency be there? Ah, because the dependency on DP is >> for (DECON || FIMD), but as DECON doesn't provide >> fimd_dp_clock_enable(), it doesn't seem like it would compile if you >> selected DECON and not FIMD. >> >> So, for me, the cleanest solution would be config DRM_EXYNOS_DP gains >> a hard dependency on DRM_EXYNOS_FIMD, at least until it can be fixed >> to compile without FIMD. > > Right, you correctly pointed current dependencies. Still it looks little > hacky because EXYNOS_DP may work with FIMD or DECON. Are you sure? I have not seen any chipset having DECON and DP. In all chipsets known to me DP is always accompanied by FIMD. I guess it can change in the future, but for now hard dependency on FIMD seems to be OK - it just reflects hardware design. Of course this is just my humble opinion :) Regards Andrzej It does not really > need FIMD. Using ifdefs in headers is not uncommon - many core > subsystems do this that way to provide stubs. > > Probably the cleanest way would be to provide by FIMD and DECON a common > interface for DP for such operation, something like: > struct exynos_drm_crtc { > struct drm_crtc base; > ... > void (*clock_enable)(struct exynos_drm_crtc *crtc, bool enable) > ); > > which, if non-NULL, will be called by exynos_dp_core.c: > static void exynos_dp_poweron(struct exynos_dp_device *dp) > { > ... > if (crtc->clock_enable) > crtc->clock_enable(crtc, true); > } > > What do you think? > > Best regards, > Krzysztof > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753333AbbEDNQE (ORCPT ); Mon, 4 May 2015 09:16:04 -0400 Received: from mailout4.w1.samsung.com ([210.118.77.14]:58303 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753190AbbEDNPS (ORCPT ); Mon, 4 May 2015 09:15:18 -0400 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 X-AuditID: cbfec7f4-f79c56d0000012ee-f9-554770e3d54b Content-transfer-encoding: 8BIT Message-id: <554770E1.2000401@samsung.com> Date: Mon, 04 May 2015 15:15:13 +0200 From: Andrzej Hajda User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 Newsgroups: gmane.linux.kernel.samsung-soc,gmane.linux.kernel,gmane.comp.video.dri.devel,gmane.linux.ports.arm.kernel To: Krzysztof Kozlowski , Daniel Stone Cc: Inki Dae , linux-samsung-soc , Seung-Woo Kim , Linux Kernel Mailing List , dri-devel , Kyungmin Park , Kukjin Kim , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH] drm/exynos: Fix build breakage on !DRM_EXYNOS_FIMD References: <1430539706-2945-1-git-send-email-k.kozlowski.k@gmail.com> <55472339.8040408@samsung.com> <5547696D.8000300@gmail.com> In-reply-to: <5547696D.8000300@gmail.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrFLMWRmVeSWpSXmKPExsVy+t/xK7qPC9xDDf5N17C40jqd1eLK1/ds FpPuT2CxeP7vB7tF/+PXzBZnm96wW2x6fI3V4vKuOWwWM87vY7KYMfklmwOXx4uv25g9ds66 y+6xaVUnm8f97uNMHpuX1Hv0bVnF6PF5k1wAexSXTUpqTmZZapG+XQJXRvsFq4IX4hUzNhs0 MH4W6mLk5JAQMJE4++QCE4QtJnHh3nq2LkYuDiGBpYwSN1fOZQZJ8AoISvyYfI+li5GDg1lA XuLIpWwIU11iypRciPLnjBJf571kgSjXkmg+0QlmswioSnSe+w02hk1AU+Lv5ptsIL2iAhES 3ScqQcJ8AuUSO65vACsRAQp/XvCaDcRmFuhjluh9HANiCwu4S9y/coMFYtdZRoktTw+xgiQ4 gWY2L+hgncAoOAvJpbMQLp2FcOkCRuZVjKKppckFxUnpuYZ6xYm5xaV56XrJ+bmbGCEx8mUH 4+JjVocYBTgYlXh4F8i6hwqxJpYVV+YeYpTgYFYS4Q2PAArxpiRWVqUW5ccXleakFh9ilOZg URLnnbvrfYiQQHpiSWp2ampBahFMlomDU6qBcZVY/cr0+lqRndyiKt9EYudLaty+XPUusPDH xOZMK8MfC92TPVe7RW+dcELC/3vJ+S6Rs6ucuM9qvvN677gv4FL73W3f97pwZ71qFnx1X2mq POO+ree5hXhuP+0WSf2aF7ZlT8Jm5rm/JvysW/8lsP0m63KGM1ybX5rOdZqyMeWi171fxp6V 8UosxRmJhlrMRcWJAI++KSiNAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 05/04/2015 02:43 PM, Krzysztof Kozlowski wrote: > 2015-05-04 20:34 GMT+09:00 Daniel Stone : >> Hi, >> >> On 4 May 2015 at 08:43, Inki Dae wrote: >>> On 2015년 05월 02일 13:08, Krzysztof Kozlowski wrote: >>>> Selecting CONFIG_FB_S3C disables CONFIG_DRM_EXYNOS_FIMD leading to build >>>> error: >>> >>> No, eDP has no any dependency of FIMD but DECON. Just add dependency >>> code like below, >>> >>> config DRM_EXYNOS7_DECON >>> bool "Exynos DRM DECON" >>> - depends on DRM_EXYNOS >>> + depends on DRM_EXYNOS && !FB_S3C > > Actually my commit message was not detailed enough. The FB_S3C here > won't solve the issue because you may: > 1, disable FIMD and FB_S3C, > 2, enabke DECON and DP, > and it won't compile. > > Currently the FIMD must be enabled if DRM_EXYNOS_DP is enabled. > >> >> But it does clearly and explicitly call fimd_dp_clock_enable from >> exynos_dp_powero{n,ff}. So the dependency you're proposing seems >> backwards: it's not an expression of the requirements of the current >> code (that FIMD DP code be available, i.e. CONFIG_DRM_EXYNOS_FIMD is >> selected), but an indirect expression of another dependency >> (CONFIG_FB_S3C disables CONFIG_DRM_EXYNOS_FIMD, so disable >> CONFIG_FB_S3C). >> >> Additionally, as the call comes from exynos_dp_core.c, which is built >> by CONFIG_DRM_EXYNOS_DP (an explicitly user-selectable option), why >> shouldn't the dependency be there? Ah, because the dependency on DP is >> for (DECON || FIMD), but as DECON doesn't provide >> fimd_dp_clock_enable(), it doesn't seem like it would compile if you >> selected DECON and not FIMD. >> >> So, for me, the cleanest solution would be config DRM_EXYNOS_DP gains >> a hard dependency on DRM_EXYNOS_FIMD, at least until it can be fixed >> to compile without FIMD. > > Right, you correctly pointed current dependencies. Still it looks little > hacky because EXYNOS_DP may work with FIMD or DECON. Are you sure? I have not seen any chipset having DECON and DP. In all chipsets known to me DP is always accompanied by FIMD. I guess it can change in the future, but for now hard dependency on FIMD seems to be OK - it just reflects hardware design. Of course this is just my humble opinion :) Regards Andrzej It does not really > need FIMD. Using ifdefs in headers is not uncommon - many core > subsystems do this that way to provide stubs. > > Probably the cleanest way would be to provide by FIMD and DECON a common > interface for DP for such operation, something like: > struct exynos_drm_crtc { > struct drm_crtc base; > ... > void (*clock_enable)(struct exynos_drm_crtc *crtc, bool enable) > ); > > which, if non-NULL, will be called by exynos_dp_core.c: > static void exynos_dp_poweron(struct exynos_dp_device *dp) > { > ... > if (crtc->clock_enable) > crtc->clock_enable(crtc, true); > } > > What do you think? > > Best regards, > Krzysztof >