From: John Snow <jsnow@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: marc.mari.barcelo@gmail.com, pbonzini@redhat.com,
stefanha@redhat.com, qemu-devel@nongnu.org,
qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH v3 0/9] ahci: enable migration
Date: Mon, 04 May 2015 11:40:04 -0400 [thread overview]
Message-ID: <554792D4.5010401@redhat.com> (raw)
In-Reply-To: <20150504122942.GG3676@noname.str.redhat.com>
On 05/04/2015 08:29 AM, Kevin Wolf wrote:
> Am 30.04.2015 um 20:07 hat John Snow geschrieben:
>> The day we all feared is here, and I am proposing we allow the migration
>> of the AHCI device tentatively for the 2.4 development window.
>>
>> There are some more NCQ migration tests are needed, but I felt that it was
>> important to get migration enabled as close to the start of the 2.4
>> development window as possible.
>>
>> If the NCQ patches don't pan out by the time the 2.4 freeze occurs, we can
>> revert the migration boolean and add a conditional around the ahci tests
>> that rely on the migration feature being enabled.
>>
>> I am justifying this checkin based on a series of ping-pong
>> migration tests I ran under heavy load (using google's stressapptest)
>> and saw over 300 successful migrations without a single failure.
>>
>> This series does a few things:
>> (1) Add migration facilities to libqos
>> (2) Enable AHCI and ICH9 migration
>> (3) Add a series of migration tests to ahci-test
>
> Reviewed-by: Kevin Wolf <kwolf@redhat.com>
>
> I think besides the NCQ tests, we'll definitely also want to test
> migration with READ DMA in flight (this series tests only WRITE DMA and
> FLUSH CACHE). Probably also discard.
>
Added to the todo list, thanks.
> Nice to have, but less important, would be the other variants that
> exist, like the EXT version of each command, and READ/WRITE SECTOR.
>
> But all of that can be added in a follow-up series, it's not a reason to
> hold up what's already there.
>
> Kevin
>
Thanks!
--js
next prev parent reply other threads:[~2015-05-04 15:40 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-30 18:07 [Qemu-devel] [PATCH v3 0/9] ahci: enable migration John Snow
2015-04-30 18:07 ` [Qemu-devel] [PATCH v3 1/9] libqos/ahci: Add halted command helpers John Snow
2015-04-30 18:07 ` [Qemu-devel] [PATCH v3 2/9] libqos/ahci: Fix sector set method John Snow
2015-04-30 18:07 ` [Qemu-devel] [PATCH v3 3/9] libqos: Add migration helpers John Snow
2015-05-04 12:07 ` [Qemu-devel] [Qemu-block] " Kevin Wolf
2015-05-04 17:52 ` John Snow
2015-05-05 11:35 ` Kevin Wolf
2015-05-05 15:50 ` John Snow
2015-04-30 18:07 ` [Qemu-devel] [PATCH v3 4/9] ich9/ahci: Enable Migration John Snow
2015-04-30 18:07 ` [Qemu-devel] [PATCH v3 5/9] qtest/ahci: Add migration test John Snow
2015-04-30 18:07 ` [Qemu-devel] [PATCH v3 6/9] qtest/ahci: add migrate dma test John Snow
2015-04-30 18:07 ` [Qemu-devel] [PATCH v3 7/9] qtest/ahci: add flush migrate test John Snow
2015-04-30 18:07 ` [Qemu-devel] [PATCH v3 8/9] qtest/ahci: add halted dma test John Snow
2015-04-30 18:07 ` [Qemu-devel] [PATCH v3 9/9] qtest/ahci: add migrate " John Snow
2015-05-04 12:29 ` [Qemu-devel] [Qemu-block] [PATCH v3 0/9] ahci: enable migration Kevin Wolf
2015-05-04 15:40 ` John Snow [this message]
2015-05-05 22:45 ` [Qemu-devel] " John Snow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=554792D4.5010401@redhat.com \
--to=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=marc.mari.barcelo@gmail.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.