From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH 05/13] KVM: x86: pass host_initiated to functions that
 read MSRs
Date: Mon, 04 May 2015 18:04:37 +0200
Message-ID: <55479895.4030400@redhat.com>
References: <1430393772-27208-1-git-send-email-pbonzini@redhat.com> <1430393772-27208-6-git-send-email-pbonzini@redhat.com> <20150504140143.GA11234@potion.brq.redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: QUOTED-PRINTABLE
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, bsd@redhat.com,
	guangrong.xiao@linux.intel.com,
	Yang Zhang <yang.z.zhang@intel.com>, wanpeng.li@linux.intel.com
To: =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= <rkrcmar@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:37418 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1750820AbbEDQEn (ORCPT <rfc822;kvm@vger.kernel.org>);
	Mon, 4 May 2015 12:04:43 -0400
In-Reply-To: <20150504140143.GA11234@potion.brq.redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>



On 04/05/2015 16:01, Radim Kr=C4=8Dm=C3=A1=C5=99 wrote:
>>  static int emulator_get_msr(struct x86_emulate_ctxt *ctxt,
>>  			    u32 msr_index, u64 *pdata)
>>  {
>> -	return kvm_get_msr(emul_to_vcpu(ctxt), msr_index, pdata);
>> +	struct msr_data msr;
>> +	int r;
>> +
>> +	msr.index =3D msr_index;
>> +	msr.host_initiated =3D false;
>> +	r =3D kvm_get_msr(emul_to_vcpu(ctxt), &msr);
>> +	if (r)
>> +		return r;
>> +
>> +	*pdata =3D msr.data;
>> +	return 0;
>>  }
>=20
> (Only msr.host_initiated changed from do_get_msr() ...
>  I'd add a function with an extra bool arg and call it twice.)

True, but the same situation is there already for do_set_msr vs.
emulator_set_msr

Paolo