From: Jens Axboe <axboe@fb.com>
To: Shaohua Li <shli@fb.com>, <linux-kernel@vger.kernel.org>
Cc: <Kernel-team@fb.com>
Subject: Re: [PATCH] blk-mq: fix FUA request hang
Date: Mon, 4 May 2015 13:10:40 -0600 [thread overview]
Message-ID: <5547C430.7040105@fb.com> (raw)
In-Reply-To: <c2d7d3579d640b4a4bc4151fd042705ad797400a.1430499496.git.shli@fb.com>
On 05/01/2015 10:59 AM, Shaohua Li wrote:
> When a FUA request enters its DATA stage of flush pipeline, the
> request is added to mq requeue list, the request will then be added to
> ctx->rq_list. blk_mq_attempt_merge() might merge the request with a bio.
> Later when the request is finished the flush pipeline, the
> request->__data_len is 0. Then I only saw the bio gets endio called, the
> original request never finish.
>
> Adding REQ_FLUSH_SEQ into REQ_NOMERGE_FLAGS looks an easy fix.
Thanks, applied.
--
Jens Axboe
prev parent reply other threads:[~2015-05-04 19:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-01 16:59 [PATCH] blk-mq: fix FUA request hang Shaohua Li
2015-05-04 19:10 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5547C430.7040105@fb.com \
--to=axboe@fb.com \
--cc=Kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=shli@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.