Re: [Qemu-devel] [PATCH v4 13/17] qcow2/overlaps: Add "memory limit reached" event

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1277 bytes --]

On 05/04/2015 01:15 PM, Max Reitz wrote:
> Later, a mechanism to set a limit on how much memory may be used for the
> overlap prevention structures will be introduced. If that limit is about
> to be exceeded, a QMP event should be emitted. This very event is
> specified by this patch.
> 
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> ---
>  docs/qmp/qmp-events.txt | 28 ++++++++++++++++++++++++++++
>  qapi/event.json         | 27 +++++++++++++++++++++++++++
>  2 files changed, 55 insertions(+)

> +
> +Data:
> +- "reference": Device name if set; node name otherwise. (json-string)
> +- "start":     Offset of the range of clusters (possibly) no longer being
> +               checked for writes overlapping with existing metadata.
> +               (json-int, optional)
> +- "length":    Length of that range in bytes. (json-int, optional)
> +
> +Example:
> +
> +{ "event": "QCOW2_OVERLAP_CHECK_MEMORY_LIMIT_REACHED",
> +    "data": { "reference": "virtio0", "start": "805306368",
> +              "length": "268435456" },

s/"805306368"/805306368/ and likewise for length (a json-int does not
use quotes).

Otherwise seems okay.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]