From: Jens Axboe <axboe@kernel.dk>
To: Brian Fulton <bfulton@google.com>
Cc: Akash Verma <akashv@google.com>, fio <fio@vger.kernel.org>
Subject: Re: [Bug report] Runtime, IOPS, bandwidth recorded incorrectly if small size with time_based
Date: Mon, 04 May 2015 16:02:27 -0600 [thread overview]
Message-ID: <5547EC73.5030001@kernel.dk> (raw)
In-Reply-To: <CANff2=M1nm3GhJ-3RWVyzMHx9WE-SdO=eUUdwOKmC39HT9HQ-A@mail.gmail.com>
On 05/04/2015 03:25 PM, Brian Fulton wrote:
> Hi Jens,
>
> I've been actively looking at this bug. It was introduced with change
> e5437a073e658e8154b9e87bab5c7b3b06ed4255
> (https://github.com/axboe/fio/commit/e5437a073e658e8154b9e87bab5c7b3b06ed4255).
>
> In this change, the time granularity was changed from microseconds to
> milliseconds. This change assumes that all loops take at least 1ms to
> complete. This is not always true and tests where the loop gets
> processed, regularly, in sub-millisecond time result in many zeroes
> being summed which, ultimately, causes a completely inaccurate
> runtime.
>
> I have a fix for this, but I want to verify that it doesn't break
> anything as it is changing the way the runtime is being calculated.
>
> We are using fio version 2.2.6, though this issue should still be
> present in the latest version (2.2.7).
>
>
> Below is a patch fix based of the latest version of fio 2.2.7:
Thanks, that makes more sense. Akash, can you confirm that this fixes it
for you?
--
Jens Axboe
next prev parent reply other threads:[~2015-05-04 22:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-24 22:50 [Bug report] Runtime, IOPS, bandwidth recorded incorrectly if small size with time_based Akash Verma
2015-05-04 20:42 ` Jens Axboe
2015-05-04 21:25 ` Brian Fulton
2015-05-04 22:02 ` Jens Axboe [this message]
2015-05-04 22:08 ` Jens Axboe
2015-05-04 23:17 ` Brian Fulton
2015-05-05 0:37 ` Jens Axboe
2015-05-05 1:12 ` Brian Fulton
2015-05-15 17:32 ` Brian Fulton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5547EC73.5030001@kernel.dk \
--to=axboe@kernel.dk \
--cc=akashv@google.com \
--cc=bfulton@google.com \
--cc=fio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.