Re: [PATCH 2/2] am335x-evm: add bluetooth support

[Peter Hurley <peter@hurleysoftware.com>]

Hi Rob,

On 05/04/2015 06:28 PM, Rob Herring wrote:
> On Sun, May 3, 2015 at 7:19 AM, Eyal Reizer <eyalreizer@gmail.com> wrote:
>> From: Eliad Peller <eliad@wizery.com>
>>
>> uart1 is used for shared transport (used for multiplexing
>> bluetooth and nfc data). add the needed muxes and definitions.
>>
>> Signed-off-by: Eliad Peller <eliad@wizery.com>
>> Signed-off-by: Eyal Reizer <eyalr@ti.com>
>> ---
>>  arch/arm/boot/dts/am335x-evm.dts |   28 ++++++++++++++++++++++++++++
>>  1 file changed, 28 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/am335x-evm.dts b/arch/arm/boot/dts/am335x-evm.dts
>> index 0f398fa..5968cde 100644
>> --- a/arch/arm/boot/dts/am335x-evm.dts
>> +++ b/arch/arm/boot/dts/am335x-evm.dts
>> @@ -135,6 +135,18 @@
>>                 };
>>         };
>>
>> +       kim {
>> +               compatible = "kim";
> 
> Who is kim?

drivers/misc/ti-st/st_kim.c, et.al.

>> +               nshutdown_gpio = <117>; /* Bank3, pin21 */
> 
> We have a standard way to specify gpios.
> 
>> +               dev_name = "/dev/ttyS1";
> 
> Uh, Linux specific. No.
> 
>> +               flow_cntrl = <1>;
>> +               baud_rate = <3000000>;
> 
> I believe there are standard properties for uarts for both of these.
>
> Is any of this documented?

See commit 46d0d333 ("ti-st: add device tree support").

Don't shoot the messenger; I had nothing to do with this.

Regards,
Peter Hurley