From: Eric Sandeen <sandeen@sandeen.net>
To: Dave Chinner <david@fromorbit.com>
Cc: fstests@vger.kernel.org
Subject: Re: [PATCH 3/4] xfs/045: can't change UUID on v5 filesystems.
Date: Mon, 04 May 2015 21:04:07 -0500 [thread overview]
Message-ID: <55482517.9090205@sandeen.net> (raw)
In-Reply-To: <20150505005112.GK15810@dastard>
On 5/4/15 7:51 PM, Dave Chinner wrote:
> On Mon, May 04, 2015 at 05:48:31PM -0500, Eric Sandeen wrote:
>> On 5/4/15 5:01 PM, Dave Chinner wrote:
>>> From: Dave Chinner <dchinner@redhat.com>
>>>
>>> So pass "-m crc=0" to the scratch_mkfs command so that we only run
>>> on old v4 format filesystems where the UUID can be changed.
>>>
>>> Signed-off-by: Dave Chinner <dchinner@redhat.com>
>>
>> hm, given that I might "fix" this should we instead trap
>> on an xfs_db uuid failure, and _notrun the test?
>> (oh, but older xfs_db let it go, didn't it. sigh).
>>
>> I guess nothing about the presence of crc vs. non-crc
>> matters for this test, so turning it off by default is probably ok.
>> It could use a comment about why it's got "-m crc=0" though, at
>> least.
>
> Added. New patch below.
>
Thanks.
Reviewed-by: Eric Sandeen <sandeen@redhat.com>
next prev parent reply other threads:[~2015-05-05 2:04 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-04 22:01 [PATCH 0/4] fstests: xfs utility output has changed Dave Chinner
2015-05-04 22:01 ` [PATCH 1/4] filter: latest mkfs.xfs makes logical sector size noise Dave Chinner
2015-05-04 22:45 ` Eric Sandeen
2015-05-04 22:01 ` [PATCH 2/4] filter: latest xfs_repair is more verbose Dave Chinner
2015-05-04 22:46 ` Eric Sandeen
2015-05-04 22:01 ` [PATCH 3/4] xfs/045: can't change UUID on v5 filesystems Dave Chinner
2015-05-04 22:48 ` Eric Sandeen
2015-05-05 0:51 ` Dave Chinner
2015-05-05 2:04 ` Eric Sandeen [this message]
2015-05-04 22:01 ` [PATCH 4/4] filter: inode size output of mkfs.xfs can change Dave Chinner
2015-05-05 2:06 ` Eric Sandeen
2015-05-05 5:34 ` Dave Chinner
2015-05-06 7:19 ` Eryu Guan
2015-05-06 22:56 ` Dave Chinner
2015-05-07 3:05 ` Eryu Guan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55482517.9090205@sandeen.net \
--to=sandeen@sandeen.net \
--cc=david@fromorbit.com \
--cc=fstests@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.