From: Daniel Borkmann <daniel@iogearbox.net>
To: Florian Westphal <fw@strlen.de>, netdev@vger.kernel.org
Cc: jhs@mojatatu.com, alexei.starovoitov@gmail.com
Subject: Re: [PATCH -next 4/5] net: sched: remove AT INGRESS/EGRESS
Date: Tue, 05 May 2015 13:06:46 +0200 [thread overview]
Message-ID: <5548A446.90901@iogearbox.net> (raw)
In-Reply-To: <1430765318-13788-5-git-send-email-fw@strlen.de>
On 05/04/2015 08:48 PM, Florian Westphal wrote:
> use single marker to propagate location.
> tc_at_ingress 1: ingress, 0 is egress.
>
> The new flag is set/unset in sch_ingress instead of the core.
> We will also no longer set skb->tc_verd to AT_EGRESS in the xmit
> handler.
>
> Signed-off-by: Florian Westphal <fw@strlen.de>
...
> diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
> index 911d84e..d794077 100644
> --- a/include/linux/skbuff.h
> +++ b/include/linux/skbuff.h
> @@ -488,6 +488,7 @@ static inline u32 skb_mstamp_us_delta(const struct skb_mstamp *t1,
> * @queue_mapping: Queue mapping for multiqueue devices
> * @xmit_more: More SKBs are pending for this queue
> * @tc_from_ingress: skb is processed during rx, not transmit
> + * @tc_at_ingress: skb is processed during rx, not transmit
Minor nit:
I think both comments needs to be a bit more clear. I.e. tc_at_ingress
tells the *current* location whether we are invoked from ingress or
egress. And, tc_from_ingress explains the *previous* location, whether
the skbs has been mirred from ingress path or egress path.
Otherwise, the rest looks good to me.
Acked-by: Daniel Borkmann <daniel@iogearbox.net>
next prev parent reply other threads:[~2015-05-05 11:06 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-04 18:48 [PATCH -next 0/5] replace skb tc_verd member with 3 dedicated bit flags Florian Westphal
2015-05-04 18:48 ` [PATCH -next 1/5] net: sched: replace NCLS macro with tc_nocls bit flag Florian Westphal
2015-05-05 10:38 ` Daniel Borkmann
2015-05-05 23:15 ` David Miller
2015-05-04 18:48 ` [PATCH -next 2/5] net: sched: use counter to break reclassify loops Florian Westphal
2015-05-05 10:47 ` Daniel Borkmann
2015-05-04 18:48 ` [PATCH -next 3/5] net: sched: remove FROM INGRESS/EGRESS Florian Westphal
2015-05-05 10:51 ` Daniel Borkmann
2015-05-04 18:48 ` [PATCH -next 4/5] net: sched: remove AT INGRESS/EGRESS Florian Westphal
2015-05-05 11:06 ` Daniel Borkmann [this message]
2015-05-05 11:11 ` Florian Westphal
2015-05-04 18:48 ` [PATCH -next 5/5] skbuff: remove tc_verd member Florian Westphal
2015-05-05 11:09 ` Daniel Borkmann
2015-05-05 11:39 ` [PATCH -next 0/5] replace skb tc_verd member with 3 dedicated bit flags Jamal Hadi Salim
2015-05-05 11:47 ` Florian Westphal
2015-05-05 11:58 ` Jamal Hadi Salim
2015-05-05 12:37 ` Daniel Borkmann
2015-05-05 13:22 ` Jamal Hadi Salim
2015-05-05 13:06 ` Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5548A446.90901@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=alexei.starovoitov@gmail.com \
--cc=fw@strlen.de \
--cc=jhs@mojatatu.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.