From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44465) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ype1P-0008GU-U6 for qemu-devel@nongnu.org; Tue, 05 May 2015 10:40:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ype1M-0007Pr-9S for qemu-devel@nongnu.org; Tue, 05 May 2015 10:40:31 -0400 Received: from lhrrgout.huawei.com ([194.213.3.17]:8280) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ype1M-0007Pf-1A for qemu-devel@nongnu.org; Tue, 05 May 2015 10:40:28 -0400 Message-ID: <5548D648.1080400@huawei.com> Date: Tue, 5 May 2015 16:40:08 +0200 From: Claudio Fontana MIME-Version: 1.0 References: In-Reply-To: Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 6/7] monitor: "i": Add ARM specifics List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Crosthwaite , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, claudio.fontana@gmail.com, Peter Crosthwaite , agraf@suse.de, edgari@xilinx.com, edgar.iglesias@gmail.com, rth@twiddle.net On 05.05.2015 06:45, Peter Crosthwaite wrote: > Add the ARM specific disassembly flags setup, so ARM can be correctly > disassembled from the monitor. > > Signed-off-by: Peter Crosthwaite > --- > monitor.c | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/monitor.c b/monitor.c > index d831d98..9d9f1e2 100644 > --- a/monitor.c > +++ b/monitor.c > @@ -1217,6 +1217,17 @@ static void memory_dump(Monitor *mon, int count, int format, int wsize, > int flags; > flags = 0; > env = mon_get_cpu(); > +#ifdef TARGET_ARM > + if (env->thumb) { > + flags |= 1; > + } > + if (env->bswap_code) { > + flags |= 2; > + } > + if (env->aarch64) { > + flags |= 4; > + } > +#endif > #ifdef TARGET_I386 > if (wsize == 2) { > flags = 1; > Reviewed-by: Claudio Fontana Tested-by: Claudio Fontana