From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH v3 3/3] x86/hvm: Use white-lists for HVM
 param guest accessibility checks
Date: Tue, 5 May 2015 15:43:44 +0100
Message-ID: <5548D720.5000809@citrix.com>
References: <1430821547-5783-1-git-send-email-paul.durrant@citrix.com>
	<1430821547-5783-4-git-send-email-paul.durrant@citrix.com>
	<5548A12C.70302@citrix.com>
	<9AAE0902D5BC7E449B7C8E4E778ABCD0258C14C2@AMSPEX01CL01.citrite.net>
	<5548EFDD0200007800076C2F@mail.emea.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <Andrew.Cooper3@citrix.com>) id 1Ype8M-000608-Vu
	for xen-devel@lists.xenproject.org; Tue, 05 May 2015 14:47:43 +0000
In-Reply-To: <5548EFDD0200007800076C2F@mail.emea.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>, Paul Durrant <Paul.Durrant@citrix.com>, "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: "Keir (Xen.org)" <keir@xen.org>
List-Id: xen-devel@lists.xenproject.org

On 05/05/15 15:29, Jan Beulich wrote:
>>>> On 05.05.15 at 16:09, <Paul.Durrant@citrix.com> wrote:
>>> From: Andrew Cooper [mailto:andrew.cooper3@citrix.com]
>>> Sent: 05 May 2015 11:54
>>> On 05/05/15 11:25, Paul Durrant wrote:
>>>> @@ -5657,21 +5664,11 @@ static int hvm_allow_set_param(struct domain
>>> *d,
>>>>      case HVM_PARAM_IDENT_PT:
>>>>      case HVM_PARAM_DM_DOMAIN:
>>>>      case HVM_PARAM_ACPI_S_STATE:
>>> I think you can safely elide the above cases into default.  All that
>>> matters in this case is that none of the whitelisted parameters need to
>>> pause the domain.
>>>
>> I think you and Jan differ there, unless I misunderstood Jan.
> Right, I specifically asked for these to be retained. It's just that
> the comment preceding them is not visible from the patch
> context, so that purpose isn't obvious here.

I would question its usefulness as documentation, given that its
position in the code is now removed from the actual implementation.

However, I am not sufficiently fussed to block an otherwise-good change.

~Andrew