From: Anna Schumaker <Anna.Schumaker@netapp.com>
To: Stefan Hajnoczi <stefanha@redhat.com>, <linux-nfs@vger.kernel.org>
Cc: Anna Schumaker <anna.schumaker@netapp.com>,
Trond Myklebust <trond.myklebust@primarydata.com>,
"J. Bruce Fields" <bfields@fieldses.org>
Subject: Re: [PATCH] SUNRPC: drop stale setup_socket doc comments
Date: Tue, 5 May 2015 13:10:39 -0400 [thread overview]
Message-ID: <5548F98F.5050601@Netapp.com> (raw)
In-Reply-To: <1430835480-29982-1-git-send-email-stefanha@redhat.com>
Hi Stefan,
On 05/05/2015 10:18 AM, Stefan Hajnoczi wrote:
> xs_local_setup_socket() and xs_tcp_setup_socket() have outdated
> arguments listed in the doc comments. Drop arguments that no longer
> exist.
Can you please fix up xs_local_data_ready(), xs_udp_data_ready(), and xs_tcp_data_ready() while you're at it?
Thanks!
Anna
>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
> net/sunrpc/xprtsock.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/net/sunrpc/xprtsock.c b/net/sunrpc/xprtsock.c
> index 66891e3..a8d6c6e 100644
> --- a/net/sunrpc/xprtsock.c
> +++ b/net/sunrpc/xprtsock.c
> @@ -1886,9 +1886,7 @@ static int xs_local_finish_connecting(struct rpc_xprt *xprt,
>
> /**
> * xs_local_setup_socket - create AF_LOCAL socket, connect to a local endpoint
> - * @xprt: RPC transport to connect
> * @transport: socket transport to connect
> - * @create_sock: function to create a socket of the correct type
> */
> static int xs_local_setup_socket(struct sock_xprt *transport)
> {
> @@ -2125,9 +2123,6 @@ out:
>
> /**
> * xs_tcp_setup_socket - create a TCP socket and connect to a remote endpoint
> - * @xprt: RPC transport to connect
> - * @transport: socket transport to connect
> - * @create_sock: function to create a socket of the correct type
> *
> * Invoked by a work queue tasklet.
> */
>
next prev parent reply other threads:[~2015-05-05 17:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-05 14:18 [PATCH] SUNRPC: drop stale setup_socket doc comments Stefan Hajnoczi
2015-05-05 17:10 ` Anna Schumaker [this message]
2015-05-06 8:26 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5548F98F.5050601@Netapp.com \
--to=anna.schumaker@netapp.com \
--cc=bfields@fieldses.org \
--cc=linux-nfs@vger.kernel.org \
--cc=stefanha@redhat.com \
--cc=trond.myklebust@primarydata.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.