From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37499)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1YpgYX-0006g2-8b
	for qemu-devel@nongnu.org; Tue, 05 May 2015 13:22:54 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1YpgYU-0003m2-Dd
	for qemu-devel@nongnu.org; Tue, 05 May 2015 13:22:53 -0400
Received: from mail-qk0-x232.google.com ([2607:f8b0:400d:c09::232]:34629)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1YpgYU-0003lP-8z
	for qemu-devel@nongnu.org; Tue, 05 May 2015 13:22:50 -0400
Received: by qkgx75 with SMTP id x75so110894528qkg.1
	for <qemu-devel@nongnu.org>; Tue, 05 May 2015 10:22:50 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <5548FC65.6050005@twiddle.net>
Date: Tue, 05 May 2015 10:22:45 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <cover.1430798763.git.crosthwaite.peter@gmail.com>
	<d99c7edf85168916b973679f34e75920d2a6b8d6.1430798763.git.crosthwaite.peter@gmail.com>
In-Reply-To: <d99c7edf85168916b973679f34e75920d2a6b8d6.1430798763.git.crosthwaite.peter@gmail.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 5/7] disas: arm-a64: Make printfer and
	stream variable
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Crosthwaite <crosthwaitepeter@gmail.com>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, claudio.fontana@gmail.com, Peter Crosthwaite <crosthwaite.peter@gmail.com>, agraf@suse.de, edgari@xilinx.com, edgar.iglesias@gmail.com

On 05/04/2015 09:45 PM, Peter Crosthwaite wrote:
> -    explicit QEMUDisassembler(FILE *stream) : stream_(stream) { }
> +    explicit QEMUDisassembler() { }

The explicit is no longer helpful, and I'd still initialize stream_ to null.


r~