From: Kukjin Kim <kgene-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Krzysztof Kozlowski
<k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
Cc: Vasily Khoruzhick
<anarsoul-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Kukjin Kim <kgene-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>,
linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] i2c: s3c2410: fix oops in suspend callback for non-dt platforms
Date: Wed, 06 May 2015 06:28:39 +0900 [thread overview]
Message-ID: <55493607.3070400@kernel.org> (raw)
In-Reply-To: <CAJKOXPd71vnup-RZYAh7UM2Tky2M64tA=u0Ydy=ti0yOC6h5aQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On 05/04/15 08:50, Krzysztof Kozlowski wrote:
> 2015-05-04 3:13 GMT+09:00 Vasily Khoruzhick <anarsoul-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>:
>> Initialize sysreg by default, otherwise driver will crash in suspend callback.
>>
>> Signed-off-by: Vasily Khoruzhick <anarsoul-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>
> I think the crash is possible if device node is missing in DT or pdata
> is supplied. If you agree, could you add this information to commit
> message, along with Cc-stable and Fixes tag?
>
> Anyway, the patch itself looks good:
> Reviewed-by: Krzysztof Kozlowski <k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
>
Can you please add me in Cc in your next posting?
I can't see the patch in my mail box...
- Kukjin
next prev parent reply other threads:[~2015-05-05 21:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-03 18:13 [PATCH] i2c: s3c2410: fix oops in suspend callback for non-dt platforms Vasily Khoruzhick
2015-05-03 23:50 ` Krzysztof Kozlowski
[not found] ` <CAJKOXPd71vnup-RZYAh7UM2Tky2M64tA=u0Ydy=ti0yOC6h5aQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-05-04 17:52 ` Vasily Khoruzhick
[not found] ` <CA+E=qVdjvx=0PSh-ead_pABd9D=bG3ua1FFRTSN2U5BVf2a=Og-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-05-05 1:46 ` Krzysztof Kozlowski
2015-05-05 21:28 ` Kukjin Kim [this message]
2015-05-05 21:30 ` Kukjin Kim
[not found] ` <1430676790-30500-1-git-send-email-anarsoul-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-05-12 16:15 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55493607.3070400@kernel.org \
--to=kgene-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=anarsoul-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.