All of lore.kernel.org
 help / color / mirror / Atom feed
From: nick <xerofoify@gmail.com>
To: Dave Chinner <david@fromorbit.com>
Cc: jack@suse.cz, bfoster@redhat.com, sandeen@sandeen.net,
	linux-kernel@vger.kernel.org, xfs@oss.sgi.com, hch@lst.de
Subject: Re: [PATCH 01/12] xfs:Make the function,xfs_alloc_lookup_eq static
Date: Tue, 05 May 2015 18:16:22 -0400	[thread overview]
Message-ID: <55494136.6010405@gmail.com> (raw)
In-Reply-To: <20150505221209.GG21261@dastard>



On 2015-05-05 06:12 PM, Dave Chinner wrote:
> On Tue, May 05, 2015 at 04:16:28PM -0400, Nicholas Krause wrote:
>> This makes the function,xfs_alloc_lookup_eq static as there are no
>> calls to this function outside the definition file for this function,
>> xfs_alloc.c.
>>
>> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
>> ---
>>  fs/xfs/libxfs/xfs_alloc.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/fs/xfs/libxfs/xfs_alloc.c b/fs/xfs/libxfs/xfs_alloc.c
>> index 516162b..48de3f0 100644
>> --- a/fs/xfs/libxfs/xfs_alloc.c
>> +++ b/fs/xfs/libxfs/xfs_alloc.c
>> @@ -52,7 +52,7 @@ STATIC int xfs_alloc_ag_vextent_small(xfs_alloc_arg_t *,
>>  /*
>>   * Lookup the record equal to [bno, len] in the btree given by cur.
>>   */
>> -STATIC int				/* error */
>> +static int				/* error */
>>  xfs_alloc_lookup_eq(
>>  	struct xfs_btree_cur	*cur,	/* btree cursor */
>>  	xfs_agblock_t		bno,	/* starting block of extent */
> 
> Please have a look at what STATIC actually means, and then use the
> sparse checker to confirm that these functions are already static
> for a CONFIG_XFS_DEBUG=n build.
> 
> i.e. STATIC is a stack usage minimisation and debugging aid, not
> something that is broken and needs fixing.
> 
> Cheers,
> 
> Dave.
> 
That's Ok I wasn't sure if that was there for those reasons.Next time 
I will be more careful and check out the macros I don't known. :(
Sorry,
Nick 

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

      reply	other threads:[~2015-05-05 22:16 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-05 20:16 [PATCH 01/12] xfs:Make the function,xfs_alloc_lookup_eq static Nicholas Krause
2015-05-05 20:16 ` [PATCH 02/12] xfs:Make the function,xfs_alloc_update static Nicholas Krause
2015-05-05 20:16 ` [PATCH 03/12] xfs:Make the function,xfs_alloc_compute_aligned static Nicholas Krause
2015-05-05 20:16 ` [PATCH 04/12] xfs:Make the function,xfs_alloc_fix_len static Nicholas Krause
2015-05-05 20:16 ` [PATCH 05/12] xfs:Make the function, xfs_alloc_fix_minleft static Nicholas Krause
2015-05-05 20:16 ` [PATCH 06/12] xfs:Make the function,xfs_alloc_fixup_trees static Nicholas Krause
2015-05-05 20:16 ` [PATCH 07/12] xfs:Make the function,xfs_alloc_read_agfl static Nicholas Krause
2015-05-05 20:16 ` [PATCH 08/12] xfs:Make the function,xfs_alloc_update_counters static Nicholas Krause
2015-05-05 20:16 ` [PATCH 09/12] xfs:Make the function,xfs_alloc_ag_vextent static Nicholas Krause
2015-05-05 20:16 ` [PATCH 10/12] xfs:Make the function, xfs_alloc_find_best_extent static Nicholas Krause
2015-05-05 20:16 ` [PATCH 11/12] xfs:Make the function,xfs_free_ag_extent static Nicholas Krause
2015-05-05 20:16 ` [PATCH 12/12] xfs:Make the function,xfs_alloc_fix_freelist static Nicholas Krause
2015-05-05 20:18 ` [PATCH 01/12] xfs:Make the function,xfs_alloc_lookup_eq static Christoph Hellwig
2015-05-05 20:18   ` Christoph Hellwig
2015-05-05 20:30   ` nick
2015-05-05 22:12 ` Dave Chinner
2015-05-05 22:12   ` Dave Chinner
2015-05-05 22:16   ` nick [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55494136.6010405@gmail.com \
    --to=xerofoify@gmail.com \
    --cc=bfoster@redhat.com \
    --cc=david@fromorbit.com \
    --cc=hch@lst.de \
    --cc=jack@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sandeen@sandeen.net \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.