From: Rongqing Li <rongqing.li@windriver.com>
To: "Burton, Ross" <ross.burton@intel.com>
Cc: OE-core <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] mmc-utils: fix the building failure when DEBUG_BUILD is 1
Date: Wed, 6 May 2015 08:56:59 +0800 [thread overview]
Message-ID: <554966DB.4070907@windriver.com> (raw)
In-Reply-To: <CAJTo0LZ=0w_VY4jmhS5qPTrKh3iU66S+gWYjXC34JT059qkH1g@mail.gmail.com>
On 2015年05月05日 23:43, Burton, Ross wrote:
>
> On 23 April 2015 at 04:18, <rongqing.li@windriver.com
> <mailto:rongqing.li@windriver.com>> wrote:
>
> +export FORITY="${@base_conditional( "DEBUG_BUILD", "1", "",
> "-D_FORTIFY_SOURCE=2", d )}"
> +EXTRA_OEMAKE = 'AM_CFLAGS="-D_FILE_OFFSET_BITS=64 ${FORITY}"'
>
>
> "FORTIFY" not "FORITY", and why does that need to be exported?
>
typos, but it still fix the building failure.
> I'm also curious as to why fortify and debug builds are incompatible,
> and if there's a sufficient number of problems should we just disable
> fortify in security_flags.inc when debug builds are enabled?
>
the mmc-utils always uses the _FORTIFY_SOURCE, so we
need to override AM_CFLAGS to remove FORTIFY.
mmc-utils/git$ grep AM_CFLAGS Makefile
AM_CFLAGS = -D_FILE_OFFSET_BITS=64 -D_FORTIFY_SOURCE=2
override CFLAGS := $(CHECKFLAGS) $(AM_CFLAGS) $(CFLAGS)
mmc-utils/git$
-Roy
> Ross
--
Best Reagrds,
Roy | RongQing Li
prev parent reply other threads:[~2015-05-06 0:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-23 3:18 [PATCH] mmc-utils: fix the building failure when DEBUG_BUILD is 1 rongqing.li
2015-05-04 1:34 ` Rongqing Li
2015-05-05 15:43 ` Burton, Ross
2015-05-06 0:56 ` Rongqing Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=554966DB.4070907@windriver.com \
--to=rongqing.li@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=ross.burton@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.