Re: [PATCH] can: janz-ican3: add support for CAL/CANopen firmware

[Marc Kleine-Budde <mkl@pengutronix.de>]

[-- Attachment #1: Type: text/plain, Size: 1294 bytes --]

On 05/05/2015 08:08 PM, Andreas Gröger wrote:
> sorry, my S-o-b was invalid.
> ---
> Hi Marc, Hi Ira,
> 
> thank you very much for the positive and constructive responses,
> seems to be the right way.
> 
> String comparison for firmware identification: there is another way
> to retrieve the id and version (IDVERS-request), but it is more
> complicated. You have to await the response and the result is a
> longer string about 200 bytes. Janz recommends this firmware stamp
> for module identification.
> 
> Bittiming in ican3_set_bus_state: this affects the driver with
> ICANOS-firmware. So I asked Janz for the ICANOS-firmware to be able
> to test. I tested both firmware-variants with different baudrates:
> went as expected. Hope I met your needs.
> 
> Kind regards, Andreas
> 
> Signed-off-by: Andreas Gröger <andreas24groeger@gmail.com>

Applied to can-next. I've split the patch, first the existing sysfs
entries are documented, the second one updates the driver.

cheers,
Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 801 bytes --]