From: Paolo Bonzini <pbonzini@redhat.com>
To: Fam Zheng <famz@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
qemu-block@nongnu.org, jcody@redhat.com, armbru@redhat.com,
mreitz@redhat.com, Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [RFC PATCH 6/7] virtio-blk: Don't handle output when there is "device IO" op blocker
Date: Wed, 06 May 2015 14:07:39 +0200 [thread overview]
Message-ID: <554A040B.7030108@redhat.com> (raw)
In-Reply-To: <1430911419-8256-7-git-send-email-famz@redhat.com>
On 06/05/2015 13:23, Fam Zheng wrote:
> virtio-blk now listens to op blocker change of the associated block
> backend.
>
> Up on setting op blocker on BLOCK_OP_TYPE_DEVICE_IO:
>
> non-dataplane:
> 1) Set VirtIOBlock.paused
> 2) In virtio_blk_handle_output, do nothing if VirtIOBlock.paused
>
> dataplane:
> 1) Clear the host event notifier
> 2) In handle_notify, do nothing if VirtIOBlock.paused
>
> Up on removing the op blocker:
>
> non-dataplane:
> 1) Clear VirtIOBlock.paused
> 2) Schedule a BH on the AioContext of the backend, which calls
> virtio_blk_handle_output, so that the previous unhandled kicks can
> make progress
>
> dataplane:
> 1) Set the host event notifier
> 2) Notify the host event notifier so that unhandled events are
> processed
>
> Signed-off-by: Fam Zheng <famz@redhat.com>
Does non-dataplane need to do anything, since it uses iohandlers rather
than aio_set_event_notifier_handler?
Paolo
next prev parent reply other threads:[~2015-05-06 12:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-06 11:23 [Qemu-devel] [RFC PATCH 0/7] Fix transactional snapshot with virtio-blk dataplane Fam Zheng
2015-05-06 11:23 ` [Qemu-devel] [RFC PATCH 1/7] block: Add op blocker type "device IO" Fam Zheng
2015-05-06 11:23 ` [Qemu-devel] [RFC PATCH 2/7] block: Block "device IO" during bdrv_drain and bdrv_drain_all Fam Zheng
2015-05-06 11:23 ` [Qemu-devel] [RFC PATCH 3/7] block: Add op blocker notifier list Fam Zheng
2015-05-06 14:22 ` Paolo Bonzini
2015-05-06 15:03 ` Fam Zheng
2015-05-06 11:23 ` [Qemu-devel] [RFC PATCH 4/7] block-backend: Add blk_op_blocker_add_notifier Fam Zheng
2015-05-06 11:23 ` [Qemu-devel] [RFC PATCH 5/7] virtio-blk: Move complete_request to 'ops' structure Fam Zheng
2015-05-06 11:23 ` [Qemu-devel] [RFC PATCH 6/7] virtio-blk: Don't handle output when there is "device IO" op blocker Fam Zheng
2015-05-06 12:07 ` Paolo Bonzini [this message]
2015-05-06 12:20 ` Fam Zheng
2015-05-06 14:18 ` Paolo Bonzini
2015-05-06 11:23 ` [Qemu-devel] [RFC PATCH 7/7] blockdev: Add "device IO" op blocker during snapshot transaction Fam Zheng
2015-05-07 13:43 ` [Qemu-devel] [Qemu-block] [RFC PATCH 0/7] Fix transactional snapshot with virtio-blk dataplane Stefan Hajnoczi
2015-05-08 8:46 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=554A040B.7030108@redhat.com \
--to=pbonzini@redhat.com \
--cc=armbru@redhat.com \
--cc=famz@redhat.com \
--cc=jcody@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.