From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56987)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1Ypz1S-0001MA-Qx
	for qemu-devel@nongnu.org; Wed, 06 May 2015 09:05:59 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1Ypz1M-00054B-Ed
	for qemu-devel@nongnu.org; Wed, 06 May 2015 09:05:58 -0400
Message-ID: <554A11AA.2040004@redhat.com>
Date: Wed, 06 May 2015 15:05:46 +0200
From: Max Reitz <mreitz@redhat.com>
MIME-Version: 1.0
References: <1430766953-6913-1-git-send-email-mreitz@redhat.com>
	<1430766953-6913-14-git-send-email-mreitz@redhat.com>
	<5547C939.6040207@redhat.com>
In-Reply-To: <5547C939.6040207@redhat.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v4 13/17] qcow2/overlaps: Add "memory limit
	reached" event
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>, qemu-block@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>

On 04.05.2015 21:32, Eric Blake wrote:
> On 05/04/2015 01:15 PM, Max Reitz wrote:
>> Later, a mechanism to set a limit on how much memory may be used for the
>> overlap prevention structures will be introduced. If that limit is about
>> to be exceeded, a QMP event should be emitted. This very event is
>> specified by this patch.
>>
>> Signed-off-by: Max Reitz <mreitz@redhat.com>
>> ---
>>   docs/qmp/qmp-events.txt | 28 ++++++++++++++++++++++++++++
>>   qapi/event.json         | 27 +++++++++++++++++++++++++++
>>   2 files changed, 55 insertions(+)
>> +
>> +Data:
>> +- "reference": Device name if set; node name otherwise. (json-string)
>> +- "start":     Offset of the range of clusters (possibly) no longer being
>> +               checked for writes overlapping with existing metadata.
>> +               (json-int, optional)
>> +- "length":    Length of that range in bytes. (json-int, optional)
>> +
>> +Example:
>> +
>> +{ "event": "QCOW2_OVERLAP_CHECK_MEMORY_LIMIT_REACHED",
>> +    "data": { "reference": "virtio0", "start": "805306368",
>> +              "length": "268435456" },
> s/"805306368"/805306368/ and likewise for length (a json-int does not
> use quotes).

Oops, right. Will fix.

> Otherwise seems okay.

Good, thanks :-)

Max