From: Jens Axboe <axboe@kernel.dk>
To: Linus Torvalds <torvalds@linux-foundation.org>,
Herbert Xu <herbert@gondor.apana.org.au>
Cc: Christophe Leroy <christophe.leroy@c-s.fr>,
Al Viro <viro@zeniv.linux.org.uk>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Linux Crypto Mailing List <linux-crypto@vger.kernel.org>
Subject: Re: [PATCH v2] splice: sendfile() at once fails for big files
Date: Wed, 06 May 2015 08:23:48 -0600 [thread overview]
Message-ID: <554A23F4.7010004@kernel.dk> (raw)
In-Reply-To: <CA+55aFyc+A25ozSTVNNHmBL_kUhv9u5kUq9esxjYggmqfPRE9w@mail.gmail.com>
On 05/05/2015 09:41 PM, Linus Torvalds wrote:
> Jens, ping?
>
> The test results should make this a no-brainer, but I hate how random
> these flag ops.
Missed the original, apparently. I too am confused how this is a
correctness fix and not just an optimization.
+ if (read_len < len)
+ sd->flags |= SPLICE_F_MORE;
+ else if (!more)
+ sd->flags &= ~SPLICE_F_MORE;
Should that check be for 'more', not '!more'?
--
Jens Axboe
next prev parent reply other threads:[~2015-05-06 14:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-23 15:03 [PATCH v2] splice: sendfile() at once fails for big files Christophe Leroy
2015-04-27 7:01 ` Herbert Xu
2015-05-06 3:41 ` Linus Torvalds
2015-05-06 4:34 ` Christoph Hellwig
2015-05-06 14:23 ` Jens Axboe [this message]
2015-05-06 14:38 ` leroy christophe
2015-05-06 14:40 ` Jens Axboe
2015-05-06 14:40 ` Jens Axboe
2015-05-06 15:07 ` Jens Axboe
2015-05-06 15:07 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=554A23F4.7010004@kernel.dk \
--to=axboe@kernel.dk \
--cc=christophe.leroy@c-s.fr \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.