From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55732)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Leon.Alrae@imgtec.com>) id 1Yq1wB-0006EI-Ge
	for qemu-devel@nongnu.org; Wed, 06 May 2015 12:12:44 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Leon.Alrae@imgtec.com>) id 1Yq1w5-0001O2-Hu
	for qemu-devel@nongnu.org; Wed, 06 May 2015 12:12:43 -0400
Received: from mailapp01.imgtec.com ([195.59.15.196]:50049)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Leon.Alrae@imgtec.com>) id 1Yq1w5-0001Ne-Ct
	for qemu-devel@nongnu.org; Wed, 06 May 2015 12:12:37 -0400
Message-ID: <554A3D6E.6090702@imgtec.com>
Date: Wed, 6 May 2015 17:12:30 +0100
From: Leon Alrae <leon.alrae@imgtec.com>
MIME-Version: 1.0
References: <1430924229-20469-1-git-send-email-leon.alrae@imgtec.com>
	<5893E888-3F42-496F-B6D1-C954C513A3CE@livius.net>
In-Reply-To: <5893E888-3F42-496F-B6D1-C954C513A3CE@livius.net>
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 0/4] semihosting: clean up and add
 --semihosting-config arg
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Liviu Ionescu <ilg@livius.net>
Cc: peter.maydell@linaro.org, christopher.covington@linaro.org, qemu-devel@nongnu.org, matthew.fortune@imgtec.com

On 06/05/2015 16:22, Liviu Ionescu wrote:
> 
> apparently your patch does not fix the arm semihosting problems. do you plan a separate patch for this?

This patchset doesn't contain any target semihosting specific changes
(just a clean up and new arg option). I'm going to follow up with UHI
patch series only. I don't have anything set up to test other
semihosting interfaces, thus I don't plan to do any changes in these
areas in near future. Therefore feel free to send your ARM semihosting
improvements.

> 
> 
>> bool semihosting_enabled(void)
>> {
>>     return semihosting.allowed;
>> }
> 
> any particular reason for naming the structure member ".allowed" and the getter function "_enabled()"?

Generally no, but patch #1 introduced semihosting_enabled() function,
hence this change. However, thanks for pointing this out as I just
realized that with the patch #3 this rename was not required at all.
I'll correct that.

Thanks,
Leon