From: Eric Blake <eblake@redhat.com>
To: penghao122@sina.com, qemu-devel <qemu-devel@nongnu.org>
Cc: qemu-stable <qemu-stable@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] keyboard:fix ps2 keyboard can't use
Date: Wed, 06 May 2015 11:05:01 -0600 [thread overview]
Message-ID: <554A49BD.3070006@redhat.com> (raw)
In-Reply-To: <554A4967.2050306@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 725 bytes --]
On 05/06/2015 11:03 AM, Eric Blake wrote:
> On 05/06/2015 10:20 AM, penghao122@sina.com wrote:
>
> Missing a 'v2' in the subject line (hint: git send-email -v2)
>
>> +++ b/hw/input/pckbd.c
>> @@ -207,6 +207,8 @@ static uint64_t kbd_read_status(void *opaque, hwaddr addr,
>> KBDState *s = opaque;
>> int val;
>> val = s->status;
>> + if(s->write-cmd == KBD_CCMD_KBD_ENABLE)
>
> Your patch is fatally flawed:
Oh, and also your patch fails scripts/checkpatch.pl due to missing {}
around the 'if' body. Also something we mention on:
> PLEASE read http://wiki.qemu.org/Contribute/SubmitAPatch
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
prev parent reply other threads:[~2015-05-06 17:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-06 16:20 [Qemu-devel] [PATCH] keyboard:fix ps2 keyboard can't use penghao122
2015-05-06 17:03 ` Eric Blake
2015-05-06 17:05 ` Eric Blake [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=554A49BD.3070006@redhat.com \
--to=eblake@redhat.com \
--cc=penghao122@sina.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.