On 05/06/2015 11:03 AM, Eric Blake wrote:
> On 05/06/2015 10:20 AM, penghao122@sina.com wrote:
> 
> Missing a 'v2' in the subject line (hint: git send-email -v2)
> 

>> +++ b/hw/input/pckbd.c
>> @@ -207,6 +207,8 @@ static uint64_t kbd_read_status(void *opaque, hwaddr addr,
>> KBDState *s = opaque;
>> int val;
>> val = s->status;
>> + if(s->write-cmd == KBD_CCMD_KBD_ENABLE)
> 
> Your patch is fatally flawed:

Oh, and also your patch fails scripts/checkpatch.pl due to missing {}
around the 'if' body.  Also something we mention on:

> PLEASE read http://wiki.qemu.org/Contribute/SubmitAPatch

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org