Re: [Qemu-devel] [PULL 12/15] migration: Use an array instead of 3 parameters

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1897 bytes --]

On 05/06/2015 11:50 AM, Juan Quintela wrote:
> From: Liang Li <liang.z.li@intel.com>
> 
> Put the three parameters related to multiple thread (de)compression
> into an int array, and use an enum type to index the parameter.
> 
> Signed-off-by: Liang Li <liang.z.li@intel.com>
> Signed-off-by: Yang Zhang <yang.z.zhang@intel.com>
> Signed-off-by: Juan Quintela <quintela@redhat.com>
> ---
>  include/migration/migration.h |  4 +---
>  migration/migration.c         | 31 +++++++++++++++++++------------
>  qapi-schema.json              | 23 +++++++++++++++++++++++
>  3 files changed, 43 insertions(+), 15 deletions(-)
> 

> +++ b/qapi-schema.json
> @@ -569,6 +569,29 @@
>  ##
>  { 'command': 'query-migrate-capabilities', 'returns':   ['MigrationCapabilityStatus']}
> 
> +# @MigrationParameter
> +#
> +# Migration parameters enumeration
> +#
> +# @compress-level: Set the compression level to be used in live migration,
> +#          the compression level is an integer between 0 and 9, where 0 means
> +#          no compression, 1 means the best compression speed, and 9 means best
> +#          compression ratio which will consume more CPU.
> +#
> +# @compress-threads: Set compression thread count to be used in live migration,
> +#          the compression thread count is an integer between 1 and 255.
> +#
> +# @decompress-threads: Set decompression thread count to be used in live
> +#          migration, the decompression thread count is an integer between 1
> +#          and 255. Usually, decompression is at least 4 times as fast as
> +#          compression, so set the decompress-threads to the number about 1/4
> +#          of compress-threads is adequate.
> +#
> +# Since: 2.3

s/2.3/2.4/ (okay as part of the followup patch)

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]