From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH 09/13] KVM: x86: save/load state on SMM switch Date: Wed, 06 May 2015 21:38:42 +0200 Message-ID: <554A6DC2.3010903@redhat.com> References: <1430393772-27208-1-git-send-email-pbonzini@redhat.com> <1430393772-27208-10-git-send-email-pbonzini@redhat.com> <5549EF71.4080207@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, rkrcmar@redhat.com, guangrong.xiao@linux.intel.com, Yang Zhang , wanpeng.li@linux.intel.com To: Bandan Das Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 06/05/2015 19:55, Bandan Das wrote: > Valid point. But I would say cryptic names will always be better then > hex offsets. It's a one time pain in the neck to get the defines > right. > > I found this header - > ftp://ftp.xskernel.org/soft/linux-src/bochs-20080511/cpu/smm.h > > Maybe we can pick it up ? I can sanity check the list and > make sure the offsets are correct if you prefer. Thanks, I like that header. :) No need to sanity check yourself. I'll have to adjust to define both 32-bit and 64-bit offsets. Ok to use just SMRAM32_OFS_xyz and SMRAM64_OFS_xyz? No need for LO32 and HI32, in particular. The one problem is that I am doing math on the offsets in some places. It would suck to save/restore 16 registers manually. Any suggestions? I will probably send v1 for review without the offsets. Paolo