All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steve Dickson <SteveD@redhat.com>
To: Gregory Boyce <gregory.boyce@gmail.com>, linux-nfs@vger.kernel.org
Subject: Re: [PATCH] nfs-utils: Allow users to disable mount option rewriting via norewriteopts mount option
Date: Wed, 06 May 2015 16:14:30 -0400	[thread overview]
Message-ID: <554A7626.1050709@RedHat.com> (raw)
In-Reply-To: <alpine.DEB.2.10.1504201417410.5338@valhalla.home>



On 04/20/2015 02:18 PM, Gregory Boyce wrote:
> Allow users to disable mount option rewriting via norewriteopts mount option.
> This was required in our case in order to allow mounting a filer which inappropriately responded via the wrong interface.
> 
> Signed-off-by: Gregory Boyce <gregory.boyce@gmail.com>
Again... This is fixing a filer bug, correct? 

We generally don't do that... 

steved.

> ---
>  utils/mount/stropts.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/utils/mount/stropts.c b/utils/mount/stropts.c
> index df67fac..bbda754 100644
> --- a/utils/mount/stropts.c
> +++ b/utils/mount/stropts.c
> @@ -534,6 +534,14 @@ nfs_rewrite_pmap_mount_options(struct mount_options *options, int checkv4)
>      struct pmap mnt_pmap;
> 
>      /*
> +     * "norewriteopts" option bypasses the options rewriting
> +     */
> +    if (po_contains(options, "norewriteopts") == PO_FOUND) {
> +        po_remove_all(options, "norewriteopts");
> +        return 1;
> +    }
> +
> +    /*
>       * Version and transport negotiation is not required
>       * and does not work for RDMA mounts.
>       */

  reply	other threads:[~2015-05-06 20:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-20 18:18 [PATCH] nfs-utils: Allow users to disable mount option rewriting via norewriteopts mount option Gregory Boyce
2015-05-06 20:14 ` Steve Dickson [this message]
2015-05-06 20:28   ` Gregory Boyce
2015-05-07 13:48     ` Steve Dickson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=554A7626.1050709@RedHat.com \
    --to=steved@redhat.com \
    --cc=gregory.boyce@gmail.com \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.