From: Hans Verkuil <hverkuil@xs4all.nl>
To: Linux Media Mailing List <linux-media@vger.kernel.org>
Cc: Sakari Ailus <sakari.ailus@iki.fi>,
Federico Vaga <federico.vaga@gmail.com>
Subject: Re: [PATCH] sta2x11: use monotonic timestamp
Date: Thu, 07 May 2015 08:27:20 +0200 [thread overview]
Message-ID: <554B05C8.3010309@xs4all.nl> (raw)
In-Reply-To: <554B0496.7050902@xs4all.nl>
Added Federico to the CC-list.
On 05/07/2015 08:22 AM, Hans Verkuil wrote:
> V4L2 drivers should use MONOTONIC timestamps instead of gettimeofday, which is
> affected by daylight savings time.
>
> diff --git a/drivers/media/pci/sta2x11/sta2x11_vip.c b/drivers/media/pci/sta2x11/sta2x11_vip.c
> index d384a6b..59b3a36 100644
> --- a/drivers/media/pci/sta2x11/sta2x11_vip.c
> +++ b/drivers/media/pci/sta2x11/sta2x11_vip.c
> @@ -813,7 +813,7 @@ static irqreturn_t vip_irq(int irq, struct sta2x11_vip *vip)
> /* Disable acquisition */
> reg_write(vip, DVP_CTL, reg_read(vip, DVP_CTL) & ~DVP_CTL_ENA);
> /* Remove the active buffer from the list */
> - do_gettimeofday(&vip->active->vb.v4l2_buf.timestamp);
> + v4l2_get_timestamp(&vip->active->vb.v4l2_buf.timestamp);
> vip->active->vb.v4l2_buf.sequence = vip->sequence++;
> vb2_buffer_done(&vip->active->vb, VB2_BUF_STATE_DONE);
> }
> @@ -864,6 +864,7 @@ static int sta2x11_vip_init_buffer(struct sta2x11_vip *vip)
> vip->vb_vidq.buf_struct_size = sizeof(struct vip_buffer);
> vip->vb_vidq.ops = &vip_video_qops;
> vip->vb_vidq.mem_ops = &vb2_dma_contig_memops;
> + vip->vb_vidq.timestamp_flags = V4L2_BUF_FLAG_TIMESTAMP_MONOTONIC;
> err = vb2_queue_init(&vip->vb_vidq);
> if (err)
> return err;
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2015-05-07 6:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-07 6:22 [PATCH] sta2x11: use monotonic timestamp Hans Verkuil
2015-05-07 6:27 ` Hans Verkuil [this message]
2015-05-07 12:21 ` Federico Vaga
2015-05-07 6:33 ` Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=554B05C8.3010309@xs4all.nl \
--to=hverkuil@xs4all.nl \
--cc=federico.vaga@gmail.com \
--cc=linux-media@vger.kernel.org \
--cc=sakari.ailus@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.