From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH] KVM: x86: Call-far should not be emulated as stack op Date: Thu, 07 May 2015 11:31:02 +0200 Message-ID: <554B30D6.2030001@redhat.com> References: <1430673777-15451-1-git-send-email-namit@cs.technion.ac.il> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Nadav Amit Return-path: Received: from mx1.redhat.com ([209.132.183.28]:34294 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750880AbbEGJbM (ORCPT ); Thu, 7 May 2015 05:31:12 -0400 In-Reply-To: <1430673777-15451-1-git-send-email-namit@cs.technion.ac.il> Sender: kvm-owner@vger.kernel.org List-ID: On 03/05/2015 19:22, Nadav Amit wrote: > Far call in 64-bit has a 32-bit operand size. Remove the marking of this > operation as Stack so it can be emulated correctly in 64-bit. > > Signed-off-by: Nadav Amit > --- > arch/x86/kvm/emulate.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c > index 630bcb0..5839fc5 100644 > --- a/arch/x86/kvm/emulate.c > +++ b/arch/x86/kvm/emulate.c > @@ -3840,7 +3840,7 @@ static const struct opcode group5[] = { > F(DstMem | SrcNone | Lock, em_inc), > F(DstMem | SrcNone | Lock, em_dec), > I(SrcMem | NearBranch, em_call_near_abs), > - I(SrcMemFAddr | ImplicitOps | Stack, em_call_far), > + I(SrcMemFAddr | ImplicitOps, em_call_far), > I(SrcMem | NearBranch, em_jmp_abs), > I(SrcMemFAddr | ImplicitOps, em_jmp_far), > I(SrcMem | Stack, em_push), D(Undefined), > Applied, thanks. Paolo