From: Jacek Anaszewski <j.anaszewski@samsung.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Alexandre Courbot <gnurou@gmail.com>,
Bryan Wu <cooloney@gmail.com>, Richard Purdie <rpurdie@rpsys.net>,
Arnd Bergmann <arnd@arndb.de>,
linux-gpio@vger.kernel.org, linux-leds@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] leds: leds-gpio: Add missing #include <linux/of.h>
Date: Thu, 07 May 2015 14:15:05 +0200 [thread overview]
Message-ID: <554B5749.60801@samsung.com> (raw)
In-Reply-To: <1430986090-7243-3-git-send-email-geert@linux-m68k.org>
On 05/07/2015 10:08 AM, Geert Uytterhoeven wrote:
> drivers/leds/leds-gpio.c: In function ‘gpio_leds_create’:
> drivers/leds/leds-gpio.c:194: error: implicit declaration of function ‘of_node’
> drivers/leds/leds-gpio.c:194: warning: assignment makes pointer from integer without a cast
> drivers/leds/leds-gpio.c:200: error: dereferencing pointer to incomplete type
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
> drivers/leds/leds-gpio.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/leds/leds-gpio.c b/drivers/leds/leds-gpio.c
> index 15eb3f86f670ffe4..89d981e8f8cacf55 100644
> --- a/drivers/leds/leds-gpio.c
> +++ b/drivers/leds/leds-gpio.c
> @@ -16,6 +16,7 @@
> #include <linux/kernel.h>
> #include <linux/leds.h>
> #include <linux/module.h>
> +#include <linux/of.h>
> #include <linux/platform_device.h>
> #include <linux/property.h>
> #include <linux/slab.h>
>
Acked-by: Jacek Anaszewski <j.anaszewski@samsung.com>
--
Best Regards,
Jacek Anaszewski
next prev parent reply other threads:[~2015-05-07 12:15 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-07 8:08 [PATCH 0/3] leds: leds-gpio: Allow compile test if !GPIOLIB Geert Uytterhoeven
2015-05-07 8:08 ` [PATCH 1/3] gpiolib: Add missing dummies for the unified device properties interface Geert Uytterhoeven
2015-05-08 17:43 ` Bryan Wu
2015-05-08 17:43 ` Bryan Wu
2015-05-12 7:48 ` Geert Uytterhoeven
2015-05-12 7:48 ` Geert Uytterhoeven
2015-05-12 7:47 ` Alexandre Courbot
2015-05-12 10:31 ` Linus Walleij
2015-05-12 17:48 ` Bryan Wu
2015-05-07 8:08 ` [PATCH 2/3] leds: leds-gpio: Add missing #include <linux/of.h> Geert Uytterhoeven
2015-05-07 12:15 ` Jacek Anaszewski [this message]
2015-05-12 17:49 ` Bryan Wu
2015-05-07 8:08 ` [PATCH 3/3] leds: leds-gpio: Allow compile test if !GPIOLIB Geert Uytterhoeven
2015-05-07 12:15 ` Jacek Anaszewski
2015-05-12 10:23 ` Linus Walleij
2015-05-12 17:53 ` Bryan Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=554B5749.60801@samsung.com \
--to=j.anaszewski@samsung.com \
--cc=arnd@arndb.de \
--cc=cooloney@gmail.com \
--cc=geert@linux-m68k.org \
--cc=gnurou@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.