From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1YqLTD-0006ud-2A for mharc-grub-devel@gnu.org; Thu, 07 May 2015 09:04:07 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45782) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YqLT2-0006kM-Oq for grub-devel@gnu.org; Thu, 07 May 2015 09:04:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YqLSw-0000Ru-1c for grub-devel@gnu.org; Thu, 07 May 2015 09:03:56 -0400 Received: from mail-wi0-x22f.google.com ([2a00:1450:400c:c05::22f]:38536) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YqLSv-0000Ri-SA for grub-devel@gnu.org; Thu, 07 May 2015 09:03:49 -0400 Received: by wiun10 with SMTP id n10so59013111wiu.1 for ; Thu, 07 May 2015 06:03:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type; bh=49nNkEyLRSvwJdgPsrok0fMxQglBLx3mQ8CXGM6g88A=; b=ZE1i7r/MS5bkcIvIVS+RqNoy2PVYNpqRvrIE7EiAssDYKeveYewbZvq27M3y5qx+ov 9tWiwyNjTGzE7lZod+N8VgkgrPqBouNigqjbYRAN6jzLGpeyHOeVh/v89FEiRTTpZv0u prze1ZrQ8bAn1aykfEWVxUWbZyuES2S8S1Kp7QxDdIiay67ucX9HeJ0+YSHKUfgTdO/T C+aDFeMKUq3nVC2Xpv1QyalF0LsFZOZQnSqLec92Vp0/Bg+zo92UbQGVIx9s6Uhbo7j3 1f+0R5cB9P+qwxPawZHr88SlmKL/HW2Cn16nXE2DQOyXSZHG6zPkonWrErEvVLnag/wd M6Xg== X-Received: by 10.194.80.5 with SMTP id n5mr7366627wjx.123.1431003829228; Thu, 07 May 2015 06:03:49 -0700 (PDT) Received: from ?IPv6:2620:0:105f:fd00:863a:4bff:fe50:abc4? ([2620:0:105f:fd00:863a:4bff:fe50:abc4]) by mx.google.com with ESMTPSA id g11sm3352362wjr.25.2015.05.07.06.03.48 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 07 May 2015 06:03:48 -0700 (PDT) Message-ID: <554B62B3.2070006@gmail.com> Date: Thu, 07 May 2015 15:03:47 +0200 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.6.0 MIME-Version: 1.0 To: The development of GNU GRUB Subject: Re: Attempting to install GRUB to a disk with multiple partition labels or both partition label and filesystem. References: <20150503112133.2170d2e1@opensuse.site> In-Reply-To: <20150503112133.2170d2e1@opensuse.site> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="7OpF2O8Ou8BTcHbsUcKmhKe5OUoiEWxsu" X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:400c:c05::22f X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 May 2015 13:04:04 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --7OpF2O8Ou8BTcHbsUcKmhKe5OUoiEWxsu Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 03.05.2015 10:21, Andrei Borzenkov wrote: > Could someone explain why this message is output here? It is absolutely= > not what condition checks for >=20 > if (ctx.container > && grub_strcmp (ctx.container->partmap->name, "msdos") =3D=3D 0= > && ctx.dest_partmap > && (ctx.container->msdostype =3D=3D GRUB_PC_PARTITION_TYPE_NETB= SD > || ctx.container->msdostype =3D=3D GRUB_PC_PARTITION_TYPE_O= PENBSD)) > { > grub_util_warn ("%s", _("Attempting to install GRUB to a disk w= ith multiple partition labels or both partition label and filesystem. Th= is is not supported yet.")); > goto unable_to_embed; > } >=20 > Condition checks whether we are installing on a netbsd or openbsd > partition with nested partition label. At this point we have really no > idea whether any filesystem is present (we check for it later). So > neither "multiple partition labels" nor "filesystem" appear to have > anything to do with this check. >=20 > Also it actually skips further sanity check for reserved sector in > nested partition label and jumps directly to embedding. >=20 > So it sounds like both error message is misleading and code is out of > place (it probably should be moved after reserved sector check). >=20 > Comments? >=20 It's just bad message. We need this special check because net- and openbsd labels have metadata in the partition and we have no code currently to avoid this metadata even if filesystem there could support embedding. So perhaps something like "Embedding into partitions with OpenBSD or NetBSD metadata is not supported yet" ? > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel >=20 --7OpF2O8Ou8BTcHbsUcKmhKe5OUoiEWxsu Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iF4EAREKAAYFAlVLYrMACgkQmBXlbbo5nOs65AD8DGP4xsl5EVNMuVCK5NhldYgA ByYwEc05x3wnces6PxwBAKMkTwYWnwkdOakBRw1IvJiMdlSWZdYwqdip0HqSuIxX =oLzQ -----END PGP SIGNATURE----- --7OpF2O8Ou8BTcHbsUcKmhKe5OUoiEWxsu--