From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1YqLkR-0004Pn-IQ for mharc-grub-devel@gnu.org; Thu, 07 May 2015 09:21:55 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51939) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YqLkN-0004JZ-8g for grub-devel@gnu.org; Thu, 07 May 2015 09:21:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YqLkM-0007Nj-Fv for grub-devel@gnu.org; Thu, 07 May 2015 09:21:51 -0400 Received: from mail-wi0-x22c.google.com ([2a00:1450:400c:c05::22c]:36801) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YqLkM-0007Ne-7f for grub-devel@gnu.org; Thu, 07 May 2015 09:21:50 -0400 Received: by wizk4 with SMTP id k4so242444251wiz.1 for ; Thu, 07 May 2015 06:21:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type; bh=TAh84no2lHBzh42VOCri5RHKnD/FIOJ16FlSculC+Xg=; b=WICeu4sBz7CfLqYA6IwIIcvDyroRPRh4foLWhMbrxYFiY4RRHTYa+zzQfI5qmhRpGR fqulFl/Ent5Hw65Neh3JwHLhU4xRusk19RjOncIxNr5GkvunFrMtmhXWPithYZdCfi1z pNXDGOsXDz+AAv901j0MBYrGlc5ZwImLg+L1mvXNcDX5g6+ZELas7ayPreEaX5WjQVxp xVnmj7SvUmUDATuWRkQHUJOuK4bS9gMS3OK6XedpBL2bKq/0kr2r/04J9wu/CDBhUR7/ xmPtrGP5jRofhh1t687U7BNMT9erMLiOn7ktFs9MD6iin3GFQp6FSSBeQWKe93JABRLS hjzQ== X-Received: by 10.180.160.169 with SMTP id xl9mr6807674wib.42.1431004909557; Thu, 07 May 2015 06:21:49 -0700 (PDT) Received: from ?IPv6:2620:0:105f:fd00:863a:4bff:fe50:abc4? ([2620:0:105f:fd00:863a:4bff:fe50:abc4]) by mx.google.com with ESMTPSA id xy5sm3421459wjc.35.2015.05.07.06.21.48 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 07 May 2015 06:21:48 -0700 (PDT) Message-ID: <554B66EB.3030207@gmail.com> Date: Thu, 07 May 2015 15:21:47 +0200 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.6.0 MIME-Version: 1.0 To: The development of GNU GRUB Subject: Re: [PATCH 3/5] arm64: Remove "loaded" checking in the grub_cmd_devicetree of linux.c References: <549317B4.6080606@linaro.org> In-Reply-To: <549317B4.6080606@linaro.org> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="kSgJhjXds5Bx7oRn0sdT6wx1w2E1j0UMx" X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:400c:c05::22c X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 May 2015 13:21:52 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --kSgJhjXds5Bx7oRn0sdT6wx1w2E1j0UMx Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 18.12.2014 19:06, Fu Wei wrote: > Reason: (1)we don't need the check, actually > (2)it is a prerequisite for multiboot support >=20 That one is problematic. Normally execution of any kernel-loading commands like linux resets the boot context. Exceptions are drivemap, sendkey, acpi and memory map commands, somewhat unfortunately. I'm on the edge as to whether we should extend this behaviour to other commands.= > Signed-off-by: Fu Wei > Reviewed-by: Leif Lindholm > --- > grub-core/loader/arm64/linux.c | 7 ------- > 1 file changed, 7 deletions(-) >=20 > diff --git a/grub-core/loader/arm64/linux.c b/grub-core/loader/arm64/li= nux.c > index 987f5b9..e9e9a29 100644 > --- a/grub-core/loader/arm64/linux.c > +++ b/grub-core/loader/arm64/linux.c > @@ -185,13 +185,6 @@ grub_cmd_devicetree (grub_command_t cmd __attribut= e__ ((unused)), > void *blob =3D NULL; > int size; > =20 > - if (!loaded) > - { > - grub_error (GRUB_ERR_BAD_ARGUMENT, > - N_("you need to load the kernel first")); > - return GRUB_ERR_BAD_OS; > - } > - > if (argc !=3D 1) > return grub_error (GRUB_ERR_BAD_ARGUMENT, N_("filename expected"))= ; > =20 >=20 --kSgJhjXds5Bx7oRn0sdT6wx1w2E1j0UMx Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iF4EAREKAAYFAlVLZusACgkQmBXlbbo5nOv+xQD+JM9cj7UhkroJWCeKtn31N7JY bigC+vgVW9wwj4csyTUA/3qJFqwwTaWMABtMO02LQZ/ezs8laaQP9/WIxr0UDfBU =movp -----END PGP SIGNATURE----- --kSgJhjXds5Bx7oRn0sdT6wx1w2E1j0UMx--